Skip to content

fix(delay): Fix delay dispose #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briancavalier merged 3 commits into from
Sep 18, 2017
Merged

fix(delay): Fix delay dispose #490

briancavalier merged 3 commits into from
Sep 18, 2017

Conversation

@briancavalier
Copy link
Member

@briancavalier briancavalier commented Sep 14, 2017 •
edited
Loading

Summary

Fix bug in delay that caused pending delayed events to be propagated after dispose.

Fix #488

Todo

  • Unit tests for new or changed APIs and/or functionality
    • So far it's has proven difficult to write a simple unit test for this. I may opt for a more complex test to get this merged.

@briancavalier briancavalier mentioned this pull request Sep 14, 2017
Closed
@briancavalier briancavalier merged commit f56e073 into master Sep 18, 2017
@briancavalier briancavalier deleted the fix-488 branch September 18, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylorS TylorS Awaiting requested review from TylorS

@Frikki Frikki Awaiting requested review from Frikki

@davidchase davidchase Awaiting requested review from davidchase

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briancavalier