Skip to content

Conversation

@goldsmithb
Copy link
Contributor

@goldsmithb goldsmithb commented Dec 31, 2025

Jira Ticket


This change adds a config/cul_ldap.yml file with the credentials for csa2151 service account which enables us to query the cul ldap server without raising an auth error (see here).

It also points to the branch of the cul-ldap gem that does not throw an error when the response from the LDAP server is nil.

N.B.: config/cul_ldap.yml has been created on dev, test, and prod:

shared:
    auth:
      method: simple
      username: "uni=csa2151,ou=People,o=Columbia University,c=US"  # Distinguished Name (dn)
      password: PASSWORD

@goldsmithb goldsmithb changed the title add credentials for ldap service [ACHYDRA-1041] add credentials for ldap service Jan 5, 2026
@goldsmithb goldsmithb changed the title [ACHYDRA-1041] add credentials for ldap service [ACHYDRA-1041] Add credentials for ldap service Jan 5, 2026
gem 'cancancan'
gem 'cul-ldap'
# Point to our branch of cul-ldap -- this handles no results case for find_by_uni queries without raising an error
gem 'cul-ldap', git: 'https://github.com/cul/cul-ldap', branch: 'better-error-handling'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goldsmithb, I'm wondering if there is anything preventing the better-error-handling branch from being merged into cul-ldap master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ready to be merged in, what do you think @elohanlon? He made the changes to the gem.
In the mean time I'll make a jira ticket and a PR for that branch on cul-ldap so we can coordinate releasing a new version.

Copy link
Contributor

@JackBlackLight JackBlackLight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goldsmithb, everything looks good - approving now, but if we can merge after the better_error_handling changes are in cul-ldap main that would be ideal.

@goldsmithb
Copy link
Contributor Author

@goldsmithb, everything looks good - approving now, but if we can merge after the better_error_handling changes are in cul-ldap main that would be ideal.

Great, thanks Jack!
Eric and I finished up those changes on cul-ldap gem today, so that won't be a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants