pull request for review

[daniez]

Hi, Thanks for any help with the single-purpose app.
My main problem is that my app will not display on Heroku. I get error message and log mentioned in email.

Also, question about coding:

if Date.parse('2018-6-8') > Date.today
currently returns false which is strange to me.
Shouldn't Date.today < 2018-6-8?

If I set system time to 2018-6-8 or 2018-6-9
the above returns true, which is also kind of strange.

So I've set my app to say Nyet when condition is false and da when condition is true, which seems to make it display the correct webpage. But I'm not sure how the Date.parse and > operator are really working. I can look into that but I thought I'd mention it since I'm also having trouble with getting it on Heroku.

[PeterBell]

if will evaluate to either true or false.

Start up erb on the command line. Enter "Date.today", "Date.parse('2018-6-8
')", and "Date.parse('2018-6-8') > Date.today" and see what each returns.
Guessing you're running into issues with date types and coercion. If you
want a quick fix, google "comparing dates in ruby" and it should get you
some stack overflows with answers for getting the output you want. SO is
your friend!

On Tue, Oct 14, 2014 at 9:29 PM, daniez notifications@github.com wrote:

Hi, Thanks for any help with the single-purpose app.
My main problem is that my app will not display on Heroku. I get error
message and log mentioned in email.

Also, question about coding:

if Date.parse('2018-6-8') > Date.today
currently returns false which is strange to me.
Shouldn't Date.today < 2018-6-8?

If I set system time to 2018-6-8 or 2018-6-9
the above returns true, which is also kind of strange.

So I've set my app to say Nyet when condition is false and da when
condition is true, which seems to make it display the correct webpage. But
I'm not sure how the Date.parse and > operator are really working. I can
look into that but I thought I'd mention it since I'm also having trouble

with getting it on Heroku.

You can merge this Pull Request by running

git pull https://github.com/daniez/single-purpose master

Or view, comment on, or merge it at:

#1
Commit Summary

• added isthe2018worldcuphappening ruby and the views
• ran rubocop
• ran rubocop
• ran rubocop
• added Procfile
• changed Procfile
• changed Procfile

File Changes

• A Procfile
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-0
  (1)
• A isthe2018worldcuphappening.rb
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-1
  (11)
• A views/da.erb
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-2
  (7)
• A views/nyet.erb
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-3
  (7)

Patch Links:

• https://github.com/cuny-nytech/single-purpose/pull/1.patch
• https://github.com/cuny-nytech/single-purpose/pull/1.diff

—
Reply to this email directly or view it on GitHub
#1.

[daniez]

I'll try that, thnx. And yes, I love SO. (Where I found Date.parse!)

On Tue, Oct 14, 2014 at 9:35 PM, Peter Bell notifications@github.com
wrote:

if will evaluate to either true or false.

Start up erb on the command line. Enter "Date.today",
"Date.parse('2018-6-8
')", and "Date.parse('2018-6-8') > Date.today" and see what each returns.
Guessing you're running into issues with date types and coercion. If you
want a quick fix, google "comparing dates in ruby" and it should get you
some stack overflows with answers for getting the output you want. SO is
your friend!

On Tue, Oct 14, 2014 at 9:29 PM, daniez notifications@github.com wrote:

Hi, Thanks for any help with the single-purpose app.
My main problem is that my app will not display on Heroku. I get error
message and log mentioned in email.

Also, question about coding:

if Date.parse('2018-6-8') > Date.today
currently returns false which is strange to me.
Shouldn't Date.today < 2018-6-8?

If I set system time to 2018-6-8 or 2018-6-9
the above returns true, which is also kind of strange.

So I've set my app to say Nyet when condition is false and da when
condition is true, which seems to make it display the correct webpage.
But
I'm not sure how the Date.parse and > operator are really working. I can
look into that but I thought I'd mention it since I'm also having
trouble

with getting it on Heroku.

You can merge this Pull Request by running

git pull https://github.com/daniez/single-purpose master

Or view, comment on, or merge it at:

#1
Commit Summary

• added isthe2018worldcuphappening ruby and the views
• ran rubocop
• ran rubocop
• ran rubocop
• added Procfile
• changed Procfile
• changed Procfile

File Changes

• A Procfile
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-0
  (1)
• A isthe2018worldcuphappening.rb
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-1
  (11)
• A views/da.erb
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-2
  (7)
• A views/nyet.erb
  https://github.com/cuny-nytech/single-purpose/pull/1/files#diff-3
  (7)

Patch Links:

• https://github.com/cuny-nytech/single-purpose/pull/1.patch
• https://github.com/cuny-nytech/single-purpose/pull/1.diff

—
Reply to this email directly or view it on GitHub
#1.

—
Reply to this email directly or view it on GitHub
#1 (comment)
.