Export in global scope

[mkazlauskas]

This pull request is for Electron, where it won't export to global scope when imported as <script>

Background & Context

Also removes deprecated version field in bower.json

[cure53]

I think the version numbers are highly outdated :)

@fhemberger What do you think about the other change? I lack expertise here to judge it properly.

[fhemberger]

Tests are failing:

/home/travis/build/cure53/DOMPurify/src/purify.js:11
    root.DOMPurify = factory(root);
                   ^
TypeError: Cannot set property 'DOMPurify' of null
    at /home/travis/build/cure53/DOMPurify/src/purify.js:11:20
    at Object.<anonymous> (/home/travis/build/cure53/DOMPurify/src/purify.js:12:2)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/travis/build/cure53/DOMPurify/test/jsdom-node.js:7:17)
    at Module._compile (module.js:413:34)

[fhemberger]

I don't know what the issue is with Electron. Can you please elaborate a bit more?

[tdeekens]

We should not interact with the factory of the surrounding UMD build in the first place. This has changed after merging #206 where we export a function createDOMPurify function you can use to wrap the library onto another global. You can see an example in our test setup for jsdom here.

[cure53]

Any info or news here? @mkazlauskas

[mkazlauskas]

I'm not sure how your tests fail. What my change intended to do is export the library to global scope (window) in Electron environment in the same way as in regular browser environment. Since Electron has both require and window it kinda makes sense to export to both. Also, in my specific use case I must use it from global environment and can't use require (doing HTML Imports to load it).

[cure53]

cc @fhemberger @neilj

[cure53]

Given the massive changes in #206, does this PR still make sense?

[cure53]

Closing this for now, feel free to re-open if this still makes sense.