Conversation
calufa
reviewed
Jan 21, 2022
api/src/helperClasses.js
Outdated
| } | ||
| }); | ||
| return dedupe; | ||
| return Object.values(map); |
Contributor
Author
There was a problem hiding this comment.
Good catch, that works perfectly
junievi
force-pushed
the
scrape-uuid-from-event
branch
from
dd04b58 to
af86fcc
Compare
Contributor
Author
|
@nandanrao this PR has the removed advertising ID and all tests passing. Ready for your review |
nandanrao
reviewed
Jan 29, 2022
| }); | ||
| }); | ||
| return dedupe; | ||
| const set = new Set(rows); |
Collaborator
There was a problem hiding this comment.
I still don't understand the idea behind this. You want to avoid duplicates within batches but not across batches... why? If you want the actual full return to be deduplicated, this won't work. If you don't need that, what's the point of deduplicating it slightly? And doing it on the client can't be more efficient than doing it big query if you're doing the same thing, so I still struggle to understand the optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/sql/fetch_latest.sqlthat appends Curious Data UUID to all eventsuser_pseudo_idanddevice_advertising_idwith uuid