Use new entitySchema field for Postgres migrations#7
Merged
curranosaurus merged 1 commit intocurran/use-schema-in-postgresql-queriesfrom Oct 3, 2024
Conversation
benjonesy
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the migrations code. In particular, if you manually set a table schema, we're going to prepend the
CREATe TABLEstatement with aCREATe SCHEMA IF NOT EXISTSstatement. That's going to lead to some duplication in the migrations, but it is a lot easier than tracking the "lifetime" of the schema name inside the migration file. Persistent already uses a bit of a hack to make sure that all tables exist before fkey references are declared, so there isn't any prior art for managing this kind of thing.I tested this by hardcoding table schemas to "foo". It didn't break any tests, so presumably the migrations & queries are working well with each other.