update sqlQQ test to consider a case with a schema#8
Merged
curranosaurus merged 2 commits intomasterfrom Oct 3, 2024
Merged
Conversation
curranosaurus
commented
Oct 2, 2024
| deriving instance Eq (BackendKey backend) => Eq (PetGeneric backend) | ||
|
|
||
| deriving instance Show (BackendKey backend) => Show (PetAnimalGeneric backend) | ||
| deriving instance Eq (BackendKey backend) => Eq (PetAnimalGeneric backend) |
Owner
Author
There was a problem hiding this comment.
Not sure why this is necessary. I get a weird error when I try to do this derivation with the standard deriving Eq Show syntax.
benjonesy
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that
sqlQQdefers to the Persistent backend when generating table names, so if we fix all of those then sqlQQ should work with schemas.This test suite depends on SQLite, which we haven't updated yet, but when we do, it will witness that sqlQQ is correctly interfacing with the backend when schemas are involved.