Ignore failure to delete list comp variables#535
Merged
craigbarratt merged 1 commit intocustom-components:masterfrom Oct 18, 2023
Merged
Ignore failure to delete list comp variables#535craigbarratt merged 1 commit intocustom-components:masterfrom
craigbarratt merged 1 commit intocustom-components:masterfrom
Conversation
Member
|
Thanks for fixing this issues and submitting a PR. There are two |
When iterating over a generator expression `gen` in a list comprehension `[for x in gen]`, the local variable `x` holds the value of each generated expression. When the list comprehension is done being evaluated, the local variable `x` needs to be deleted. This was already being done. If, however, `gen` is empty, `x` is never defined, and so deleting it causes an error. This patch adds a check to ignore that error.
akonradi
force-pushed
the
empty-generator
branch
from
80ea486 to
b6e5b6c
Compare
Contributor
Author
|
Whoops, fixed. |
Member
|
Awesome! Thanks for the PR. Somehow I missed the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating over a generator expression
genin a list comprehension[for x in gen], the local variablexholds the value of each generated expression. When the list comprehension is done being evaluated, the local variablexneeds to be deleted. This was already being done. If, however,genis empty,xis never defined, and so deleting it causes an error. This patch adds a check to ignore that error.Fixes #236