Create hidden rests from <forward> tags directly
#1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Need to see if these failures have to do with incomplete final measures. |
Member
Author
|
Ah, right, I looked into this a long time ago. Okay, I understand this history better now. 944785d - xmlForward() creates hidden rests, like this PR I think we can restore it with some tweaks. |
jacobtylerwalls
force-pushed
the
hidden-rests-staff-separation
branch
from
96fbbce to
ab5055a
Compare
mscuthbert
requested changes
May 11, 2021
Member
mscuthbert
left a comment
mscuthbert
left a comment
There was a problem hiding this comment.
Looks good -- one typing error noted. (need to eventually get mypy running as part of the Test suite)
Instead of relying on makeRests() after the fact, which caused problems with PartStaff separation
…s are involved, because a final forward rest in voice 2 shouldn't necessarily be removed.
jacobtylerwalls
force-pushed
the
hidden-rests-staff-separation
branch
from
768489e to
dea5117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on makeRests() after the fact, which caused problems with PartStaff separation.
Fixes #991