test: improve code coverage from 28.1% to 84.6%

[cweill]

Summary

• Improved overall test coverage from 28.1% to 84.6% (201% increase)
• Added 2254+ lines of comprehensive test code across 7 test files
• Achieved 93-100% coverage for all generics helper functions in internal/render/helpers.go
• All tests passing (100+ test cases)

Coverage Improvements by Package

Package	Before	After	Change
internal/models	0.0%	98.0%	+98.0%
internal/render	0.0%	96.4%	+96.4%
internal/render (helpers)	0.0%	93-100%	+93-100%
internal/goparser	0.0%	73.3%	+73.3%
internal/output	8.3%	69.4%	+61.1%
gotests/process	60.7%	78.7%	+18.0%

Test Files Added/Modified

New Test Files

• internal/render/helpers_test.go (650+ lines) - Comprehensive generics testing including:

  • typeArguments() with various constraint types (any, comparable, unions, approximations)
  • mapConstraintToType() covering all constraint mappings
  • Numeric constraint handling (Integer, Ordered, Signed, Unsigned, Float, Complex)
  • Type parameter substitution in fields and receivers
  • All naming helper functions (fieldName, receiverName, etc.)

• internal/models/models_test.go (700+ lines) - Core domain model testing:

  • Expression type conversions and string representations
  • Field operations and sorting
  • Function methods (FullName, TestName, ReturnsMultiple)
  • Receiver operations and naming
  • Path operations and validation

• internal/goparser/goparser_test.go (150+ lines) - AST parsing tests:

  • Simple function parsing
  • Multiple functions and methods with receivers
  • Generic function parsing with type parameters
  • Import resolution
  • Error handling for empty/nonexistent files

• internal/render/render_test.go (215+ lines) - Template rendering tests:

  • Template initialization and loading
  • Custom template directories and named templates
  • Header rendering with imports
  • Test function generation with various options (subtests, parallel, named, go-cmp)

• internal/output/helpers_test.go - File existence checking tests

Modified Test Files

• internal/output/options_test.go - Added comprehensive Process() method tests
• gotests/process/process_test.go - Expanded with template parameter tests and option validation

Key Achievement: Generics Coverage

All generics helper functions in internal/render/helpers.go now have comprehensive test coverage:

• ✅ typeArguments() - generates concrete type arguments from constraints
• ✅ mapConstraintToType() - maps all constraint types (any, comparable, unions, ~int, numeric)
• ✅ isBasicTypeName() - validates Go basic types
• ✅ isNumericConstraintName() - handles constraints package types
• ✅ fieldType() - type parameter substitution in fields
• ✅ receiverType() - type parameter substitution in receivers

Test Plan

# All tests pass
go test -v ./...

# Coverage verification
go test -coverprofile=coverage.out ./...
go tool cover -func=coverage.out

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.27%. Comparing base (97f0e5f) to head (383dc47).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #196       +/-   ##
============================================
+ Coverage    81.70%   94.27%   +12.57%     
============================================
  Files            8        8               
  Lines          891      891               
============================================
+ Hits           728      840      +112     
+ Misses         137       34      -103     
+ Partials        26       17        -9     

see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f0e5f...383dc47. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coveralls]

coverage: 96.272% (+11.3%) from 84.978%
when pulling 383dc47 on test-coverage-improvements
into 97f0e5f on develop.

[claude]

PR Review: Test Coverage Improvement from 28.1% to 84.6%

This is an excellent effort to dramatically improve test coverage across the gotests codebase. The PR adds comprehensive testing for previously untested packages.

Strengths

1. Exceptional Coverage Improvement - Overall coverage increased from 28.1% to 84.6% (201% increase) with 2254+ lines of well-structured test code

2. Well-Structured Tests - Proper use of table-driven tests, clear naming conventions, good use of subtests with t.Run(), comprehensive edge case coverage

3. Good Test Practices - Use of t.TempDir() for temporary files, proper error handling with t.Fatal() for setup failures

4. Generics Coverage - Excellent coverage of generics helper functions with tests for various constraint types

Issues and Recommendations

1. Missing Error Assertions (process_test.go:120-127) - The Run() function is called without checking for errors. Only output string is validated.

2. Weak Assertions (process_test.go:148-155) - Template parameter test only checks non-empty output, not that parameters were actually applied.

3. Inconsistent Error Test (process_test.go:161-178) - Invalid JSON test only checks for non-empty output, not specific error messages.

4. Test Data Duplication - Several tests create similar temp files. Consider adding helper functions.

Coverage Analysis

• internal/models: 98.0% - Excellent
• internal/render: 96.4% - Excellent
• internal/goparser: 73.3% - Good, could use more edge cases
• internal/output: 69.4% - Good, needs more error path testing
• gotests/process: 78.7% - Good, needs stronger assertions

Security and Performance

• No security concerns identified
• Tests are well-optimized with proper use of table-driven tests
• All file operations properly isolated with t.TempDir()

Final Recommendation

Overall: APPROVE with minor suggestions

This PR represents a substantial improvement to test coverage and quality. The tests are well-written and follow Go best practices.

Before merging:

• Ensure all CI checks pass
• Consider addressing weak assertions in process_test.go (non-blocking)

Post-merge suggestions:

• Continue improving coverage for internal/goparser (target 85%+)
• Add integration tests for common workflows
• Consider adding benchmark tests

Great work on this comprehensive testing effort!

---

Review generated with assistance from Claude Code