Type error fix for optimistic lock with embeddable entity#24
Merged
butschster merged 1 commit intocycle:1.xfrom Feb 18, 2022
Merged
Type error fix for optimistic lock with embeddable entity#24butschster merged 1 commit intocycle:1.xfrom
butschster merged 1 commit intocycle:1.xfrom
Conversation
Contributor
Author
|
@msmakouz Hello Maxim! Could you look at this PR? |
msmakouz
approved these changes
Feb 16, 2022
Contributor
Author
|
@butschster Hello :) |
Contributor
|
Hi @wpdmitry ! Sorry for long response!. Thank you for contributing! |
roxblnfk
reviewed
Feb 22, 2022
| $command->setScope($this->field, $nodeValue); | ||
|
|
||
| return WrappedCommand::wrapCommand($command) | ||
| return WrappedStoreCommand::wrapCommand($command) |
Member
There was a problem hiding this comment.
Should be tested when an entity deletion (with and without SoftDelete behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Embeddable Entities for OptimisticLock Behavior, an occurs error:
In this PR,
Author (Embeddable entity)support for theCommentwas added and after that tests (OptimisticLock/ListenerTest.php) was crashed. As it was found out, this happens when repeated callspersistmethod of EntityManager. It turned out to fix it by replacing theWrappedCommandwith theWrappedStorageCommandfor the OptimisticLock Listener.