Fix field type checking#29
Merged
Conversation
1 task
Codecov Report
@@ Coverage Diff @@
## 1.x #29 +/- ##
============================================
- Coverage 85.27% 82.36% -2.91%
- Complexity 147 151 +4
============================================
Files 22 20 -2
Lines 387 431 +44
============================================
+ Hits 330 355 +25
- Misses 57 76 +19
|
roxblnfk
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't use ->column($this->column) here:
https://github.com/cycle/entity-behavior/blob/1.x/src/OptimisticLock.php#L126
The column has not yet been created, and this method creates it with the specified name, without a type. We can only check the column type using the type in the
Cycle\Schema\Definition\Field.Other changes