Coverage plugin does not find coverage unless visiting a page before every test

[danmaftei]

Current behavior:

If a test spec does a single cy.visit() in a before() hook, Cypress does not find window.__coverage__, and no coverage is collected.

Coverage is collected only if you do cy.visit() before every test (e.g., in beforeEach(), or at the start of every it()/specify()). This is not a performant solution.

Desired behavior:

Collect coverage for specs that do a single cy.visit() before all tests run.

Since the coverage plugin saves a reference to window.__coverage__ inside a beforeEach() hook, this can be easily done by saving this reference using cy.window().then(win => ...) in addition to relying on the cy.on('window:load', win => ...) hook. The former handles the use case where we cy.visit() once in before(), and the latter handles the case where a cy.visit() is done within a test.

I've forked the coverage plugin and verified the following changes fix the issue: danmaftei@45c1ff4

Test code to reproduce

I'll fork https://github.com/cypress-io/cypress-example-realworld and make a reproducible example if the above looks suspect or is unclear.

Versions

Cypress 3.8.1
@cypress/code-coverage 1.12.1

[jennifer-shehane]

This repo is only for issues relating to the Cypress product itself. If you want to open an issue on our code-coverage plugin, you should open it here. This issue will be moved to that repo.

[jennifer-shehane]

Essentially a duplicate of #137 but leaving open in case @bahmutov wants to close the other issue since this contains more detail.

[bahmutov]

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀