Hard coded Node.js version

[RobinKnipe]

The config in action.yml overrides any previously set node version (e.g. via actions/setup-node):

github-action/action.yml

Line 87 in ffbc361

using: 'node12'

This causes failures if the project requires a more recent version, or it depends on a recent version of @cypress/react >= v5.7.0

Ideally the action should use any version of node already available, or have a configuration switch to explicitly set the desired version (similar to actions/setup-node).

[rbayliss]

I can second this issue. It seems to be happening because of this commit, combined with the fact that this action uses the Cypress node API rather than executing it as a CLI command.

Not sure exactly how to fix this, but a temporary workaround seems to be adding a command-prefix, which triggers invoking the tests with the CLI. Eg:

- name: Cypress Tests
  uses: cypress-io/github-action@v2
  with:
    record: true
    command-prefix: "--"

This is a backdoor that ends up running a cypress command like:

npx -- cypress run ...

Not sure what the side effects of this are (we're still testing it now), but I can confirm that when run this way, it invokes with the system node version rather than the action's node version.

[RobinKnipe]

@rbayliss good shout. In case it's of interest, I found a similar workaround by explicitly adding a command config, even if it just does a basic cypress run, i.e. command: npx cypress run will also use a preconfigured node version instead of the hard-coded v12.

[rbayliss]

Just wanted to note that the nature of this issue is about to change a bit, since the bump to Node 16 just got merged into this action: #484. We're likely to still be dealing with unexpected node versions, but probably not v12 anymore.

[h2oearth]

This issue is still present in Cypress 10:-(. I use Node 14.x, but some how cypress was falling back to Node 12.x

[willitsw]

Also facing this issue with Cypress 10.

[einSelbst]

@h2oearth @willitsw guys please check if you're using a container with an old node version. This is the case in the cypress github action example code.

container: cypress/browsers:node12.18.3-chrome87-ff82

Here is a list with the available node versions, up to node 17 as of today https://github.com/cypress-io/cypress-docker-images/tree/master/browsers

[MikeMcC399]

This issue hasn't been addressed. It is not covered in the README documentation and the workflow .github/workflows/example-node-versions.yml doesn't notice the problem even though the only version of Node.js used is 16.13.0 despite the matrix definition node: [14, 16, 18].

Are there any plans to fix this in any way, either by removing it as an option from the documentation or by making it work according to the documentation?