Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Sep 29, 2025

Description

This PR adds a display option for scale bars within the images displayed.

Closes #115

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs
Copy link
Member Author

d33bs commented Sep 29, 2025

@jenna-tomkinson - in addition to other areas for this change, I'll need your help to make sure the scale bars are accurate within the notebook, thanks in advance!

@d33bs d33bs marked this pull request as ready for review September 30, 2025 16:09
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added some questions for you to address prior to merging. Also I recommend updating the example/add some documentation on how we found the um_per_pixel info. I found it via the metadata of the image.

d33bs and others added 6 commits September 30, 2025 16:23
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
@d33bs
Copy link
Member Author

d33bs commented Sep 30, 2025

Thanks @jenna-tomkinson ! Merging this in.

@d33bs d33bs merged commit d158e36 into cytomining:main Sep 30, 2025
9 checks passed
@d33bs d33bs deleted the scale-bars branch September 30, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add image scale information to images

2 participants