-
Notifications
You must be signed in to change notification settings - Fork 2
Add image scale bars display option #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jenna-tomkinson - in addition to other areas for this change, I'll need your help to make sure the scale bars are accurate within the notebook, thanks in advance! |
jenna-tomkinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I added some questions for you to address prior to merging. Also I recommend updating the example/add some documentation on how we found the um_per_pixel info. I found it via the metadata of the image.
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
|
Thanks @jenna-tomkinson ! Merging this in. |
Description
This PR adds a display option for scale bars within the images displayed.
Closes #115
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.