-
Notifications
You must be signed in to change notification settings - Fork 6
Add DeepProfiler Compatibility #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @d33bs !
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
|
Thanks @gwaybio ! I made some changes based on your comments. I left one comment open which I hope to double check on before we move forward with a merge here. |
falquaddoomi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This is a pretty complex addition, and it looks like you approached it in a structured way, so kudos for that. I left a few comments mostly about typing and style.
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
|
Thank you @gwaybio and @falquaddoomi for your reviews! After incorporating changes based on your comments into the code I'll now merge this in. |
Description
This PR adds DeepProfiler compatibility to CytoTable with necessary adjustments to existing functions. Largely this is about converting NPZ files generated from DeepProfiler into concatenated Parquet data. I used the existing test data from Pycytominer (output data only) as reference data.
Thanks for any feedback!
Closes #15
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.