Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented May 30, 2025

Description

This PR adds a demonstration notebook to the documentation and prepares CytoTable for use within notebooks. I found while working on this that I needed to adjust the warnings (so one doesn't witness warnings we can't avoid through this package from sub-dependencies) and also remove a DuckDB configuration which no longer applies (and appears to require a new dependency from ipywidgets if invoked, triggering an exception).

Aside, I also noticed that mypy was triggered by my changes in unusual ways that could take a long time to figure out and might be false positives. In general, my feeling is that we should move away from mypy and instead use ty or similar projects for modernized and perhaps easier to understand type linting. I'll create a new issue on this front.

Note: myst-parser was replaced by myst-nb to help avoid circular sphinx dependencies (otherwise results in errors).

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review May 30, 2025 15:19
@d33bs d33bs requested a review from gwaybio May 30, 2025 15:19
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
@d33bs
Copy link
Member Author

d33bs commented May 30, 2025

Thanks @gwaybio ! Merging this in after responding to your changes.

@d33bs d33bs merged commit 7792746 into cytomining:main May 30, 2025
10 checks passed
@d33bs d33bs deleted the demo-notebook branch May 30, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants