-
Notifications
You must be signed in to change notification settings - Fork 3
Add contamination detector class #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contamination detector class #216
Conversation
d33bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I left a few comments with this review; let me know if we can discuss anything to help clarify. I'm marking this as a comment for now until we see passing tests.
d33bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on these changes! Generally I thought this was looking good. Comments within check_feature_means likely needs to be addressed before a merge.
|
Also - please make sure the linting checks pass before a merge as well! |
|
@d33bs Thank you lots for the review and suggestions! I think this class is looking great and I am very excited to get this on the repository! I am merging now! |
Description
In this PR, the new "contamination detector ✨", which will be a first step when using coSMicQC. It is a class, which will perform up to 3 tests to determine if there is contamination detected, if it impacts the whole or part of the plate, and if it impacts part of the plate then identify the wells that are impacted.
This class uses two main features for identification, which relate to either abnormal texture surrounding the nucleus or non-circularity of the nucleus segmentation.
These in combination help determine if your plate is contaminated in some way that you should not continue and go back to your images to confirm.
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.