Skip to content

Conversation

@jenna-tomkinson
Copy link
Member

@jenna-tomkinson jenna-tomkinson commented May 13, 2025

Description

In this PR, the new "contamination detector ✨", which will be a first step when using coSMicQC. It is a class, which will perform up to 3 tests to determine if there is contamination detected, if it impacts the whole or part of the plate, and if it impacts part of the plate then identify the wells that are impacted.

This class uses two main features for identification, which relate to either abnormal texture surrounding the nucleus or non-circularity of the nucleus segmentation.

These in combination help determine if your plate is contaminated in some way that you should not continue and go back to your images to confirm.

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • [] I have deleted all non-relevant text in this pull request template.

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I left a few comments with this review; let me know if we can discuss anything to help clarify. I'm marking this as a comment for now until we see passing tests.

@jenna-tomkinson jenna-tomkinson requested a review from d33bs May 22, 2025 18:34
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on these changes! Generally I thought this was looking good. Comments within check_feature_means likely needs to be addressed before a merge.

@d33bs
Copy link
Member

d33bs commented May 27, 2025

Also - please make sure the linting checks pass before a merge as well!

@jenna-tomkinson
Copy link
Member Author

@d33bs Thank you lots for the review and suggestions! I think this class is looking great and I am very excited to get this on the repository! I am merging now!

@jenna-tomkinson jenna-tomkinson merged commit 36d953b into cytomining:main May 27, 2025
9 checks passed
@jenna-tomkinson jenna-tomkinson deleted the add_contamination_detector branch May 27, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants