-
Notifications
You must be signed in to change notification settings - Fork 40
Enable anndata input and output #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 94.05% 93.89% -0.17%
==========================================
Files 57 59 +2
Lines 3213 3407 +194
==========================================
+ Hits 3022 3199 +177
- Misses 191 208 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @flying-sheep , this PR follows our work in cytomining/CytoTable#351 to add |
|
I’ll take a look tomorrow! |
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An exciting milestone @d33bs ! Let's discuss this a bit more
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Philipp A. <flying-sheep@web.de>
Co-Authored-By: Philipp A. <flying-sheep@web.de> Co-Authored-By: Gregory Way <gregory.way@gmail.com>
…into anndata-input
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com> Co-Authored-By: Philipp A. <flying-sheep@web.de>
Co-Authored-By: Philipp A. <flying-sheep@web.de>
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more discussion items
Co-Authored-By: Gregory Way <gregory.way@gmail.com> Co-Authored-By: Philipp A. <flying-sheep@web.de>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @d33bs ! I have only minor comments
ilan-gold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
…into anndata-input
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
|
Thanks so much @gwaybio, @flying-sheep, and @ilan-gold for your reviews and thoughtful comments throughout! I'm going to merge this in now. |
|
Thanks @d33bs for engaging with us, we love to see it and to help! |
Description
This PR enables anndata input through
load_profiles,outputand related functionality.Closes #566
Thanks for any feedback!
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
📚 Documentation preview 📚: https://pycytominer--573.org.readthedocs.build/en/573/