Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Sep 2, 2025

Description

This PR enables anndata input through load_profiles, output and related functionality.

Closes #566

Thanks for any feedback!

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

📚 Documentation preview 📚: https://pycytominer--573.org.readthedocs.build/en/573/

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 92.05607% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.89%. Comparing base (ab809c4) to head (1bc2edd).

Files with missing lines Patch % Lines
pycytominer/cyto_utils/anndata_utils.py 90.19% 10 Missing ⚠️
pycytominer/cyto_utils/load.py 80.00% 5 Missing ⚠️
tests/test_cyto_utils/test_anndata_utils.py 96.36% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   94.05%   93.89%   -0.17%     
==========================================
  Files          57       59       +2     
  Lines        3213     3407     +194     
==========================================
+ Hits         3022     3199     +177     
- Misses        191      208      +17     
Flag Coverage Δ
unittests 93.89% <92.05%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d33bs d33bs marked this pull request as ready for review September 2, 2025 23:00
@d33bs d33bs requested a review from gwaybio September 2, 2025 23:00
@d33bs
Copy link
Member Author

d33bs commented Sep 2, 2025

Hello @flying-sheep , this PR follows our work in cytomining/CytoTable#351 to add anndata integration with pycytominer. Could we ask for thoughts on the implementation? We'd greatly appreciate any guidance you 'd have for us - thank you!

@flying-sheep
Copy link
Contributor

I’ll take a look tomorrow!

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An exciting milestone @d33bs ! Let's discuss this a bit more

d33bs and others added 9 commits September 5, 2025 10:53
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Philipp A. <flying-sheep@web.de>
Co-Authored-By: Philipp A. <flying-sheep@web.de>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
Co-Authored-By: Philipp A. <flying-sheep@web.de>
@d33bs d33bs requested a review from gwaybio September 8, 2025 02:31
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more discussion items

d33bs and others added 7 commits September 9, 2025 10:04
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Philipp A. <flying-sheep@web.de>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
@d33bs d33bs changed the title Enable anndata input Enable anndata input and output Sep 9, 2025
@d33bs d33bs requested a review from gwaybio September 9, 2025 21:29
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @d33bs ! I have only minor comments

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

d33bs and others added 13 commits September 11, 2025 15:04
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
Co-Authored-By: Ilan Gold <ilanbassgold@gmail.com>
@d33bs
Copy link
Member Author

d33bs commented Sep 12, 2025

Thanks so much @gwaybio, @flying-sheep, and @ilan-gold for your reviews and thoughtful comments throughout! I'm going to merge this in now.

@d33bs d33bs merged commit 8b7d483 into cytomining:main Sep 12, 2025
15 checks passed
@d33bs d33bs deleted the anndata-input branch September 12, 2025 22:56
@ilan-gold
Copy link
Contributor

Thanks @d33bs for engaging with us, we love to see it and to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeatureRequest: add anndata as input format

5 participants