Check against correct phpMyAdmin config permissions#488
Merged
Conversation
6 tasks
cytopia
force-pushed
the
file-permissions
branch
from
755cf61 to
d6cd97a
Compare
cytopia
force-pushed
the
file-permissions
branch
from
d6cd97a to
1ab9ff7
Compare
dvlbot
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check against correct phpMyAdmin config permissions
DESCRIPTION
Ensure to explicitly check against phpMyAdmin config.inc.php permissions and keep them at0444. If they are set differently fail in CI.Git does not store writeable bit of file permissions so I will add regression tests to ensure that
$cfg['CheckConfigurationPermissions'] = false;is always set inconfig.inc.php