Add min/max GPUs to edit tool dialog #645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarando
requested changes
Jan 5, 2026
| maxDiskSpace={maxDiskSpace} | ||
| maxCPUCore={maxCPUCore} | ||
| maxMemory={maxMemory} | ||
| maxGPU={maxGPU} |
Member
There was a problem hiding this comment.
This still needs to be destructred from props at the top of this EditToolForm component.
If this were a Typescript file, it probably would have been caught at compile-time 😖
|
|
||
| const gpu_limit = getIn(values, "container.max_gpus"); | ||
| if (gpu_limit > 0 && value > gpu_limit) { | ||
| return t("validationErrMinGpusGreaterThanMax"); |
Member
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
|
|
||
| const min_gpu_limit = getIn(values, "container.min_gpus"); | ||
| if (0 < value && value < min_gpu_limit) { | ||
| return t("validationErrMaxGpusLessThanMin"); |
Member
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
| {isAdmin && ( | ||
| <Field | ||
| name="container.min_gpus" | ||
| label={t("minGpus")} |
Member
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
| )} | ||
| <Field | ||
| name="container.max_gpus" | ||
| label={t("gpuLimit")} |
Member
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up now. I need to test it a bit more and of course there's the user-facing side to do as well, but it's the last day before break anyway, so I may as well put what I have up.