-
Notifications
You must be signed in to change notification settings - Fork 34
1.0? #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fil
wants to merge
21
commits into
master
Choose a base branch
from
no-rebin-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.0? #19
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4813d41
New features:
Fil 8b0c038
Add hexbin.translate()
Fil ae63ed5
bug with angle=0 and translate
Fil 64a6ad0
rebin after changing angle or translate
Fil 70ecdcc
expose hexbin.data() which returns the whole dataset (in a possibly d…
Fil fee0257
document hexbin.data()
Fil 7df0644
hexbin.bin(point) returns the bin that correspond to a point, without…
Fil 91c885d
all parameters should rebin the data
Fil 19248c0
Simplify things a bit:
Fil 30f4a0c
points can be removed both from unbinned even if the corresponding bi…
Fil 9cb8403
In some cases the mesh was incomplete (ex: angle=-19, translate.x = -4).
Fil 4697198
Merge 9cb8403a1d4d8df91dfdc39b6d2561581bff7297 into 03merge
Fil c1a3a72
tooling
Fil b1c5090
Merge 0.3 into 03merge
Fil 63d6c5a
merge canvas test
Fil 0a67078
ignore test/output
Fil 760375b
avoid the awkward unbinned/re-binning method of #17
Fil 21db5c8
*hexbin*() accepts iterables
Fil 3cf735e
compatibility with canvas 1-2
Fil 7b76942
link to v1
Fil 817c015
Merge branch 'master' into no-rebin-api
Fil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ | |
| dist/ | ||
| node_modules | ||
| npm-debug.log | ||
| test/output | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/bin/bash | ||
|
|
||
| for i in hexagons; do | ||
| test/render-canvas $i > test/output/$i.png \ | ||
| && [ "$(gm compare -metric rmse img/$i.png test/output/$i.png 2>&1)" = "Image Difference (RootMeanSquaredError): | ||
| Normalized Absolute | ||
| ============ ========== | ||
| Red: 0.0000000000 0.0 | ||
| Green: 0.0000000000 0.0 | ||
| Blue: 0.0000000000 0.0 | ||
| Total: 0.0000000000 0.0" ] \ | ||
| && echo -e "\x1B[1;32m✓ $2\x1B[0mtest/output/$i.png" \ | ||
| && rm -f -- test/output/$i-difference.png \ | ||
| || (gm compare -type TrueColor -highlight-style assign -highlight-color red -file test/output/$i-difference.png test/output/$i.png img/$i.png; \ | ||
| echo -e "\x1B[1;31m✗ $2\x1B[0mtest/output/$i.png\n test/output/$i-difference.png") | ||
| done |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I think we'll want to update the distribution pattern.)