Skip to content

Issues/25#53

Merged
doylejd merged 3 commits into
d8-contrib-modules:masterfrom
pjonckiere:issues/25
May 24, 2016
Merged

Issues/25#53
doylejd merged 3 commits into
d8-contrib-modules:masterfrom
pjonckiere:issues/25

Conversation

@pjonckiere
Copy link
Copy Markdown

  • config is handled by config management in core (AddThisSettingsForm & AddThisSettingsFormAdvanced)
  • the json object was just initialized, thus shouldn’t be stored as a variable
  • getServices() and getServicesJsonUrl() should live in a service
  • fixed some docblocks
  • check_url() is deprecated, so replaced by Html::escape(UrlHelper::stripDangerousProtocols($uri))
  • the AddThis class has no use anymore so can be safely removed
  • in AddThisSettingForm, the $configFactory is stored on it’s parent so there is no need to save another variable with that value

@doylejd doylejd merged commit 60304d1 into d8-contrib-modules:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants