Issues/25#53
Merged
Merged
Conversation
pjonckiere
commented
Oct 9, 2015
- config is handled by config management in core (AddThisSettingsForm & AddThisSettingsFormAdvanced)
- the json object was just initialized, thus shouldn’t be stored as a variable
- getServices() and getServicesJsonUrl() should live in a service
- fixed some docblocks
- check_url() is deprecated, so replaced by Html::escape(UrlHelper::stripDangerousProtocols($uri))
- the AddThis class has no use anymore so can be safely removed
- in AddThisSettingForm, the $configFactory is stored on it’s parent so there is no need to save another variable with that value
added 3 commits
October 9, 2015 22:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.