Conversation
Owner
da1z
commented
Mar 2, 2026
da1z
commented
- Update TypeScript peer dependency to version 5.9.3 and modify tsconfig.json to include and exclude specific directories.
- Add VSCode settings for code formatting and editor configurations
…g.json to include and exclude specific directories.
da1z
commented
Mar 2, 2026
da1z
commented
Mar 2, 2026
…tructure. Increased max statements limit in .oxlintrc.json, added consistent type definitions rule, and updated package.json to reflect new CLI entry point. Removed unused files and adjusted TypeScript configuration for better project organization.
- Introduced `agent.ts` defining `Agent` and `StructuredOutputAgent` types. - Implemented `cursor.ts` for executing agents and parsing JSON output. - Created `generate-object.ts` to generate structured output based on Zod schemas. - Added tests for `generateObject` functionality to ensure correct behavior with structured agents and error handling. - Implemented `get-agent.ts` to retrieve agents by name, starting with the cursor agent.
- Added @da1z/prompt as a dependency in package.json and bun.lock. - Updated config schema to include an optional model field for code agents. - Refactored handleResolve function to utilize the model from the config. - Introduced resolveComment function to generate structured responses for pull request comments, including diff context. - Added diffHunk property to PullRequestComment type for better context in comment resolution.
da1z
commented
Mar 2, 2026
Comment on lines
+32
to
+34
| if (sessionId) { | ||
| args.push("--resume", sessionId); | ||
| } |
- Updated `handleResolve` to log the resolved comment and reply. - Improved formatting in `generate-object.ts` templates for better readability. - Added a reply field to the response schema in `resolve-comment.ts` for structured responses. - Enhanced summary description in the response schema for clarity.
- Introduced a new `file-system.ts` file defining the `FileSystem` type. - Implemented `makeFileSystem` function to provide a method for reading files asynchronously using Bun.
…asynchronous returns
- Introduced `loadSkills` function to load configured skills from the file system, stripping frontmatter and applying config filters. - Added error handling for missing skills. - Created unit tests for `loadSkills` to validate correct loading and error scenarios.
…on option in tsconfig.json - Added `@mariozechner/pi-tui` and `effect` dependencies to both `package.json` and `bun.lock`. - Introduced `erasableSyntaxOnly` option in `tsconfig.json` for stricter type checking.
…force consistent function names for generators
- Modified handleInit function to take a Context parameter for improved dependency injection. - Updated configPath retrieval to use Effect.runSync with the provided context. - Adjusted main function to create and pass the context to handleInit.
- Updated `Agent` and `StructuredOutputAgent` types to return Promises for their methods. - Modified `cursor` function to use asynchronous execution with Bun and handle output accordingly. - Adjusted `generateObject` function to await results from agent methods. - Enhanced tests to accommodate asynchronous behavior in agent interactions.
- Introduced a new section outlining key principles for maintaining code quality and reducing technical debt. - Emphasized the importance of writing sustainable code that benefits future developers.
- Introduced a new CLI entry point in `cli.ts` to facilitate command execution. - Updated `main.ts` to handle command arguments, including error handling for missing arguments. - Implemented a new `handleReview` function to process review commands and integrated it with the existing context and configuration. - Added initial test cases for diff parsing and file filtering in `diff.test.ts`. - Created new modules for review functionality, including `diff.ts`, `prompt.ts`, and `run-review.ts`, to support skill-based code reviews.
- Implemented the parseGitRef function in git.ts to handle parsing of git references, including explicit base and head refs, defaulting head to HEAD, and treating HEAD as the latest commit. - Added unit tests for parseGitRef in git.test.ts to ensure correct functionality across various scenarios.
- Introduced `compileGlobs` function to convert string patterns into `Bun.Glob` instances. - Added `matchesAnyGlob` function to check if a given filepath matches any of the provided glob patterns.
… for improved asynchronous handling
- Updated the CLI entry point in `package.json` to point to `./src/cli/cli.ts`. - Removed the old `cli.ts` file as part of the restructuring.
- Removed the deprecated `codeAgent` object from the config schema. - Introduced `agent` and `model` fields in the `review` object for improved flexibility. - Added `getConfigPath` function to streamline configuration path retrieval. - Updated `parseConfig` function to accept a value of type `unknown` for better type safety.
- Introduced a new `Context` type in `context.ts` to encapsulate dependencies including `FileSystem`, `GitService`, and configuration details. - This addition enhances type safety and facilitates better dependency injection throughout the application.
- Updated the handleInit function to accept a Pick of the Context type, focusing on the "git" and "fs" properties for improved type safety and clarity in dependency management.
- Introduced a new `Reporter` type and implemented a console reporter for logging review events. - Updated the `Context` type to include a `reporter` property for better event tracking. - Enhanced the review workflow to emit events for review start, skill loading, findings reported, and review completion. - Added a new `reporter.ts` file to encapsulate reporting logic and event types. - Updated relevant files to utilize the new reporter, improving observability during the review process.
- Implemented the `getReviewTargetType` function to classify input strings as either "git" or "file" based on defined patterns. - Added unit tests in `review-target.test.ts` to verify the functionality of `getReviewTargetType` for various input scenarios, including glob patterns, file paths, and git references. - This addition enhances the review process by accurately identifying target types for better handling of review commands.
- Implemented the `createGitDiffFromFiles` function to generate git diff outputs for added files, handling multiple files and preserving no-newline markers. - Added unit tests in `diff.test.ts` to verify the functionality of `createGitDiffFromFiles`, including scenarios for single and multiple added files, as well as empty files. - This enhancement improves the diff generation process, facilitating better integration with version control workflows.
- Added `getVisibleFiles` function to retrieve a list of files in the git repository, including staged and untracked files. - Updated the `handleReview` function to utilize `getVisibleFiles` for handling file-based reviews, emitting appropriate events for review start. - Refactored event types in the reporter to improve clarity and consistency, including renaming events for skill completion and review completion. - Enhanced the `runReview` function to emit findings for each hunk reviewed, improving the reporting of skill findings during the review process.
…ebase. This cleanup eliminates unused functionality related to command resolution and the main entry point, enhancing maintainability.
- Updated event types in the reporter to improve clarity, including renaming events for skill tasks and completion. - Introduced new event handling for skill tasks, allowing for better tracking of file review progress and findings. - Refactored the `runReview` function to utilize effects for asynchronous handling, improving error management and reporting. - Enhanced the prompt verification process by updating skill criteria descriptions for better clarity. - Improved the overall structure of the review workflow, facilitating better integration and maintainability.
- Added functionality to log a summary of skill findings categorized by severity levels (high, medium, low) upon review completion. - Improved the reporting structure to provide clearer insights into the review process and findings.
- Modified the `getAgent` function call in `handleReview` to accept a `model` parameter from the configuration, enhancing the flexibility of agent initialization during the review process.
…kills - Removed the "da1z" bot and added a "review" section with defined skills for TDD and codebase architecture improvement. - Specified the agent and model for the review process, enhancing the configuration for better agent performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.