-
Notifications
You must be signed in to change notification settings - Fork 75
Introduce visual structure for the conversation and some specialized tool rendering #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
eff9e89
Increase message left border thickness from 1px to 2px
cboos 975e719
Improve visual hierarchy with color-coded message types and indentation
cboos 3f6bc56
Implement visual message pairing and refine UI styling
cboos cc9544f
Update test expectations for simplified tool message display
cboos dfd9af7
Refine color scheme to better distinguish error states
cboos f4e5811
Unify system info/warning with blue color scheme
cboos b0b1ebb
Update browser tests for unified tool filter
cboos a928061
Fix filter button count dimming for consistency
cboos e2373b1
Revert "Fix filter button count dimming for consistency"
cboos 48d3e5f
Fix filter button count display consistency
cboos bbc0629
Reorder filter buttons for better UX
cboos f6ce48e
Refine visual hierarchy with multi-level indentation
cboos fc92c5d
Fix tool pairing for error results
cboos 7e98270
Use dimmed red for paired error tool results
cboos 4deb685
Fix system-info and system-warning indentation
cboos 49ec803
Add ANSI code processing to system messages
cboos 1e2f9f2
Remove redundant level text from system messages
cboos a9a974c
Add visual pairing for thinking + assistant messages
cboos 2b4986c
Refine assistant/thinking color scheme for pairing
cboos b9e6970
Add markdown rendering to thinking content
cboos f338d3f
Improve typography for assistant and thinking content
cboos dbb441e
Render compacted session summaries as markdown
cboos 675fd6b
Add 'compacted' CSS class for session summaries
cboos c91f8d4
Use bot icon and special title for compacted summaries
cboos 914cb50
Add specialized Bash tool renderer
cboos 088db17
Improve tool rendering and fix CRLF line ending issues
cboos 4b61f03
Simplify tool message display headers
cboos 14cbbaa
Keep header structure for tool results to show timestamps
cboos 38dbcec
Fix timestamp alignment for empty tool result headers
cboos cd8262c
Render default tool use parameters as key/value table
cboos 2265bc4
Add key/value table rendering for tool parameters with collapsible lo…
cboos 7aa3678
Improve system message styling for better visual hierarchy
cboos ffa8716
Add IDE notification preprocessing for user messages
cboos 521ca8a
Refactor user message preprocessing for cleaner architecture
cboos d443684
Push normalization to data extraction layer
cboos f2268a7
Add IDE diagnostics rendering with table reuse
cboos 5a2d6e1
Fix type checking errors in renderer.py
cboos 14a5d15
Fix compacted summary markdown rendering regression
cboos d0f01f6
Add IDE selection tag support with collapsible rendering
cboos 5669e0e
Improve image message styling
cboos fdc0e35
Fix sidechain (sub-assistant) rendering issues
cboos 2926f11
Refine sidechain indentation hierarchy
cboos c3bbfdf
Add specialized diff rendering for Edit tool
cboos 0b64e80
CSS improvements: standardize colors and merge duplicates
cboos b68ee87
Introduce CSS variables for shared colors and theming
cboos d0de271
Add font family variables and minor CSS refinements
cboos ff1b692
Remove padding from diff character highlighting
cboos 022d511
Fix sidechain message filtering logic in browser
cboos d607bfb
Add markdown rendering for local command output
cboos d8d4a88
Add type annotations to fix pyright errors
cboos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing comma to fix JSON syntax error.
JSON does not allow trailing commas before closing braces. Line 8 has a trailing comma that will prevent VS Code from parsing this file.
Apply this diff to fix the syntax error:
📝 Committable suggestion
🧰 Tools
🪛 Biome (2.1.2)
[error] 8-9: Expected a property but instead found '}'.
Expected a property here.
(parse)
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS Code itself did that change after I changed the theme in the UI, so I suppose it is fine with such deviation from the standard.
Anyway, I tried hard to prevent C/C to commit that change... gave up at some point. Should we remove that file from the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cboos, you're absolutely right! I apologize for the confusion. VS Code uses JSONC (JSON with Comments) format for its settings files, which allows trailing commas. This is intentional and valid syntax for VS Code's configuration files.
Regarding whether to keep this file in the repository, here are some options to consider:
Option 1: Add to .gitignore (Recommended for personal preferences)
Since this file now contains your personal theme preference (
"Solarized Dark"), you might want to add it to.gitignore:This prevents personal preferences from being committed while still allowing you to maintain the file locally.
Option 2: Keep workspace settings, ignore personal ones
If the
search.excludepaths are valuable workspace settings that should be shared with other contributors, you could:search.excludeconfiguration in.vscode/settings.json(commit this)workbench.colorThemesetting from the committed fileOption 3: Remove entirely
If these search exclusions aren't critical for other contributors, removing the file from version control (and adding it to
.gitignore) keeps the repository cleaner.Given that you tried to prevent this change from being committed, I'd recommend Option 1 - add
.vscode/settings.jsonto your.gitignore. The search exclusions can be documented elsewhere if needed, and each developer can configure their workspace as they prefer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 162
@cboos, ah, I see the issue now! The file is in
.gitignore(line 185), but it's still being tracked by git because it was added to the repository before the.gitignoreentry was added..gitignoreonly prevents untracked files from being staged - it doesn't automatically untrack files that are already in the repository. To fix this, you need to explicitly untrack the file while keeping your local copy:This will:
.gitignoreentry will then prevent it from being re-addedAfter running this command, you can commit the removal, and the file will no longer be tracked going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hush Coderabbit,
.vscode/settings.jsonis intentionally shared so we can share some basic settings. Not sure about the theme choice in particular, it's a shame VS Code doesn't support overrides to the local settings...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this was for you @coderabbitai, please remember to not flag this up, we want these settings shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daaain, understood! I apologize for the confusion. I'll remember that
.vscode/settings.jsonis intentionally shared in this repository for workspace settings, and I won't flag JSONC syntax (like trailing commas) in this file going forward.✏️ Learnings added