Single responsibility principle #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTTP -> Socket으로 요구사항이 변경함에 따라 읽어오는 데이터의 타입 변화 String -> byte[] - 그로 인해 변화가 필요한 부분 연쇄적으로 수정해야하는 상황 발생함.
- 데이터 GUI로 보여주는 책임은 DataDisplayer가 담당하고, 데이터 읽기 책임은 DataLoader가 담당한다. - 데이터도 추상화함.
- Socket에서 HTTP로 변경에 따라 DataLoader만 수정하면 되고, DataDisplayer는 변경할 필요가 없다. - 또한, 그에 따라 데이터 유형도 바뀌었는데, 이는 Data 클래스만 변경하면 된다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.