Open closed principle #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drawCharacter() 메서드는 Character 클래스가 확장될 때마다 같이 수정해주야 한다. - 즉, 변경에 닫혀짔지 않는 것이다.
- drawSpecific() 메서드가 실제로 객체마다 다르게 동작할 수 있는 가능성이 높다고 상황을 가정함.
- Enemy 클래스에 새로운 경로 패턴을 추가해야 할 경우 Enemy 클래스의 draw() 메서드에도 새로운 if 문을 추가해줘야 한다. - 경로를 추가하는데 Enemy 클래스가 닫혀 있지 않은 것이다.
- 새로운 이동 패턴이 생기더라도 Enemy 클래스의 draw() 메서드는 변경되지 않으며, - 새로운 타입의 PathPattern 구현 클래스를 추가해 주기만 하면 된다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.