[US-9.3] PAC Integration & Invoice Stamping#69
Merged
dacanetdev merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
- IPACProvider interface + PacStampResult record (Application layer) - MockPACProvider: deterministic fake UUID/stamps for dev (no Finkel needed) - ICFDIService interface (Application layer) - CfdiService: LoadCert → GenerateXML → PAC.Stamp → Persist UUID/seals/QrCode Certificate always disposed in finally block - StampInvoiceCommand + handler: delegates to ICFDIService, handles Draft→Stamped - CancelInvoiceCommand + handler: validates 72h window + reason codes 01-04 - IInvoicePdfService + InvoicePdfService + InvoiceDocument (QuestPDF, A4) Shows issuer/receiver RFC, items table, stamp section (UUID, QR, cert number) Cancelled invoices show red CANCELADA banner - All services registered in both DI overloads - 0 warnings, 0 errors, 150/150 tests passing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IPACProvider+PacStampResult+MockPACProvider(always succeeds, fake UUID)ICFDIService+CfdiServiceorchestrates the full stamp flow (LoadCert → XML → Sign → PAC → Persist)StampInvoiceCommand/CancelInvoiceCommandhandlers with 72-hour validationIInvoicePdfService+InvoicePdfService+InvoiceDocument(A4, QuestPDF)Design decisions
finallyblock per CLAUDE.md requirementsTest plan
dotnet build— 0 warnings, 0 errorsdotnet test tests/Corelio.Application.Tests— 150/150 passing🤖 Generated with Claude Code