Fix unsigned int to floating point number conversion #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplest repro: Convert(Constant(uint.MaxValue), typeof(double)) Previously it would return -1, since the conv.r.un instruction wasn't used. It was only applied to uint->float, but not for double or any other integer type. Only uint/ulong was problematic, but the test covers all integer types. (nuint/nint are not supported by Linq.Expression conversions)
exyi
force-pushed
the
fix-uint-to-float-conversion
branch
from
457370f to
05fd573
Compare
Owner
|
Cool thanks. I will review and check later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplest repro:
Convert(Constant(uint.MaxValue), typeof(double))
Previously it would return -1, since the conv.r.un instruction wasn't used. It was only applied to uint->float, but not for double or any other integer type. Only uint/ulong was problematic, but the test covers all integer types.
(nuint/nint are not supported by Linq.Expression conversions)