Skip to content

Fixes #154: index mismatch in set_regularisation() #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daducci merged 3 commits into from
Dec 12, 2025
Merged

Fixes #154: index mismatch in set_regularisation() #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14920c7
Fixed bug: index mismatch between input and kept streamlines in set_r…
giuliabiolo Dec 9, 2025
8dce993
Update CHANGELOG
giuliabiolo Dec 10, 2025
7c35040
Changelog update
giuliabiolo Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
### 🐛Fixed
- Error when checking the number of streamlines in the weighted LASSO function
- Error in verifying voxel correspondence between the lesion mask passed through the dictionary and the ISO weights map
- Error when checking the number of streamlines in the grouping structure for group LASSO regularization

---
---
Expand Down
2 changes: 1 addition & 1 deletion commit/core.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,7 @@ cdef class Evaluation :
# check if group_idx contains all the indices of the input streamlines
if regularisation['regIC'] == 'group_lasso' or regularisation['regIC'] == 'sparse_group_lasso':
all_idx_in = np.sort(np.unique(np.concatenate(dictIC_params['group_idx'])))
all_idx = np.arange(self.DICTIONARY['IC']['nSTR'], dtype=np.int32)
all_idx = np.arange(self.DICTIONARY['TRK']['kept'].size, dtype=np.int32)
if np.any(all_idx_in != all_idx):
logger.error('Group indices must contain all the indices of the input streamlines')

Expand Down