chroe: use shared logger instead of passing parameters #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
现在dae的代码中logger传来传去，但事实上我们只需要两个logger
一个输出到配置文件指定路径的logger，和一个始终输出到stdout/stderr的logger
因此本pr使用logrus.StandardLogger替代了代码中的绝大部分logger
并且在run.go中使用始终输出到stdout/stderr的logger
Checklist
Full Changelogs
chroe: use shared logger instead of passing parameters
Issue Reference
Closes #[issue number]
Test Result