Enhancement - Science screen - show multiple shields in multiple lines to prevent string from being cut off

[pfroud]

In the Science screen, for targets with multiple shields, the shields are concatenated into one long string, which can get cut off by the edge of the game window:

The Game Master screen shows multiple shields in multiple rows, here is what the same target looks like in release EE-2024.12.08:

I propose the Science screen show each shield in its own row.

Notes for implementation:

In the current master branch, the Game Master screen has that code commented out:

EmptyEpsilon/src/screens/gm/gameMasterScreen.cpp

Lines 44 to 48 in db75263

	//for(int n=0; n<shield_count; n++) {
	// Note, translators: this is a compromise.
	// Because of the deferred translation the variable parameter can't be forwarded, so it'll always be a suffix.
	// ret[trMark("gm_info", "Shield") + string(n + 1)] = string(shield_level[n]) + "/" + string(shield_max[n]);
	//}

link to the commit diff which commented it out in the Game Master screen

Code in Science Screen where the long string is made:

EmptyEpsilon/src/screens/crew6/scienceScreen.cpp

Lines 399 to 402 in db75263

	for(size_t n=0; n<shields->entries.size(); n++) {
	if (n > 0)
	str += ":";
	str += string(int(shields->entries[n].level));

The Science screen has a single GuiKeyValueDisplay to show the shields, while the Game Master screen uses a std::unordered_map<string, string>. The unordered map means sometimes the shields are out of order in the Game Master screen:

[oznogon]

GM screen needs a much deeper re-implementation of pre-ECS features. Displaying shield segments on multiple rows can cause layout issues with other elements on the Science screen. Filed #2651 (clip or wrap long k/v displays) for a small-scale improvement applicable beyond this problem, and #2652 for a larger-scale improvement for already-constrained containers, particularly science DB.