Clarify GuiKeyValueDisplay::setColor() overrides #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiKeyValueDisplay::setColor() now overrides all theme colors instead of only the background color. Adds setBackColor(), setKeyColor(), and setValueColor() functions to allow more specific overrides, and useThemeColors() to reset overridden colors.
To avoid making any changes to UI behavior, replace GuiKeyValueDisplay::setColor() uses with setBackColor(), which also more accurately reflects what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuiKeyValueDisplay::setColor()overrides only the background color of a key-value display, because theme colors for key and value are given precedence over the override.setColor()to override all theme colors, including key and value text and any icon.setBackColor(),setKeyColor(), andsetValueColor()to override only the background, key and icon, and value, respectively.setColor()on Science, Engineering, and DamCon withsetBackColor()to preserve the existing behavior.This PR shouldn't change anything in the UI, and is a prerequisite for more granular key-value theming and control over UI overrides.