Made compilation on OSX a little easier and updated to use RbConfig#6
Open
system123 wants to merge 1 commit intodaikini:masterfrom
Open
Made compilation on OSX a little easier and updated to use RbConfig#6system123 wants to merge 1 commit intodaikini:masterfrom
system123 wants to merge 1 commit intodaikini:masterfrom
Conversation
OSX Compilation was not supported out of the box so I just added the correct paths and a small section to find the paths based on the OS running. Config was removed from Ruby some time ago so all those calls throw warnings, updated then to use RbConfig instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSX Compilation was not supported out of the box so I just added the correct paths and a small section to find the paths based on the OS and architecture running on the host machine. Running on OSX also requires a few paths to be added to ~/.bash_profile so I updated the readme to describe these.
Config was removed from Ruby some time ago so all those calls throw warnings, updated them to use RbConfig instead.