feat(feedback): add screenshot and console log attachments#3544
Merged
rebelchris merged 6 commits intomainfrom Feb 4, 2026
Merged
feat(feedback): add screenshot and console log attachments#3544rebelchris merged 6 commits intomainfrom
rebelchris merged 6 commits intomainfrom
Conversation
- Add screenshotUrl, screenshotId, and consoleLogs columns to Feedback entity - Add ContentImageUsedByType.Feedback for image tracking - Create migration for new feedback attachment columns - Update GraphQL schema to accept screenshot Upload and consoleLogs string - Add consoleLogs validation (max 50KB) to input schema - Handle screenshot upload with Cloudinary FreeformImage preset - Create ContentImage record linking screenshot to feedback - Update Slack notification to display screenshot and console logs indicator - Update Linear issue description with screenshot image and collapsible console logs - Pass screenshot/consoleLogs from feedbackClassify worker to Linear integration - Enhance zombie image cleanup to handle feedback-linked images Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
🍹 The Update (preview) for dailydotdev/api/prod (at 753ac83) was successful. Resource Changes Name Type Operation
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-d4720fd6 kubernetes:batch/v1:Job create
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-db-migration-ba872008 kubernetes:batch/v1:Job delete
~ vpc-native-expire-super-agent-trial-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-analytics-history-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-clickhouse-migration-ba872008 kubernetes:batch/v1:Job delete
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-posts-analytics-refresh-cron kubernetes:batch/v1:CronJob update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
+ vpc-native-api-clickhouse-migration-d4720fd6 kubernetes:batch/v1:Job create
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
... and 1 other changes |
rebelchris
commented
Feb 4, 2026
src/cron/cleanZombieImages.ts
Outdated
| // Clean feedback images where: | ||
| // 1. The feedback no longer exists (orphaned), OR | ||
| // 2. The feedback is in a terminal state (Completed, Cancelled, Spam) and older than 30 days | ||
| const feedbackOrphanCleanup = await con.query( |
Contributor
Author
There was a problem hiding this comment.
Why raw query here, rather use getRepo with params?
rebelchris
commented
Feb 4, 2026
src/integrations/linear/index.ts
Outdated
| ? `\n### Screenshot\n\n\n` | ||
| : ''; | ||
|
|
||
| // Build console logs section if present (using details tag for collapsible) |
Contributor
Author
There was a problem hiding this comment.
Let's lee the console log out for slack it will spam too much, we have it in Linear it's fine.
rebelchris
commented
Feb 4, 2026
src/schema/feedback.ts
Outdated
Comment on lines
97
to
103
| feedbackInputSchema.parse({ | ||
| category: input.category, | ||
| description: input.description, | ||
| pageUrl: input.pageUrl, | ||
| userAgent: input.userAgent, | ||
| consoleLogs: input.consoleLogs, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Why not just parse(input) ?
rebelchris
commented
Feb 4, 2026
Contributor
Author
rebelchris
left a comment
rebelchris
left a comment
There was a problem hiding this comment.
@claude see my feedback. Make sure lints pass and you respect the agents.md files.
|
Claude finished @rebelchris's task in 2m 24s —— View job Addressing Review FeedbackAll review comments from @rebelchris have been addressed:
Changes Made1. src/cron/cleanZombieImages.ts
2. src/workers/feedbackUpdatedSlack.ts
3. src/schema/feedback.ts
Note on LintingThe linter requires --- | Branch |
- Replace raw SQL query with TypeORM repository methods in cleanZombieImages cron - Remove console logs indicator from Slack notifications (kept in Linear only) - Simplify Zod validation to parse entire input object directly Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
…og-to-feedback' into eng-595-screenshot-and-console-log-to-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screenshotUrl,screenshotId, andconsoleLogscolumns to the Feedback entity with migrationscreenshot(Upload) andconsoleLogs(string, max 50KB) in the GraphQLsubmitFeedbackmutationFeedbackusedByTypeCloses ENG-595
Created by Huginn 🐦⬛