Progress so far #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cimal-basic-setup-and-parsing
…umberToFloatingPointBits.cs copy
…sing Ieee decimal basic setup and parsing
dakersnar
commented
Jan 21, 2023
|
|
||
| internal bool HasInvariantNumberSigns => _hasInvariantNumberSigns; | ||
| internal bool AllowHyphenDuringParsing => _allowHyphenDuringParsing; | ||
| public bool AllowHyphenDuringParsing => _allowHyphenDuringParsing; |
Owner
Author
There was a problem hiding this comment.
This was a hack for the prototype. Another strategy is likely needed.
Owner
Author
|
Some key things to review for this PR:
|
src/libraries/System.Private.CoreLib/src/System/Numerics/IDecimalFloatingPointIeee754.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/Decimal32.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/Decimal32.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/Decimal32.cs
Outdated
Show resolved
Hide resolved
dakersnar
commented
Jan 27, 2023
src/libraries/System.Runtime.Numerics/ref/System.Runtime.Numerics.cs
Outdated
Show resolved
Hide resolved
dakersnar
commented
Jan 27, 2023
| <ItemGroup> | ||
| <Compile Include="$(CommonTestPath)System\GenericMathHelpers.cs" Link="Common\System\GenericMathHelpers.cs" /> | ||
| <Compile Include="BigIntegerTests.GenericMath.cs" /> | ||
| <Compile Include="ComplexTests.GenericMath.cs" /> |
Owner
Author
There was a problem hiding this comment.
@tannergooding Jeff mentioned you have a method for automatically generating Generic Math tests. Can you walk me through that process at some point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.