Skip to content

perf: optimize file extension discovery in technology detection #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yacosta738 merged 1 commit into from
May 14, 2026
Merged

perf: optimize file extension discovery in technology detection #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/skills/detect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,14 @@ impl RepoMetadata {
}

if let Some(ext) = relative.extension().and_then(|e| e.to_str()) {
let dot_ext = format!(".{ext}");
// Store first occurrence for deterministic evidence.
// Note: WalkDir sort_by_file_name() ensures deterministic choice if multiple exist.
extensions
.entry(dot_ext)
.or_insert_with(|| relative_buf.clone());
extensions.entry(ext.to_string()).or_insert(relative_buf);
// Optimization: Skip string formatting and map insertions if extension already recorded.
if !extensions.contains_key(ext) {
let dot_ext = format!(".{ext}");
// Store first occurrence for deterministic evidence.
// Note: WalkDir sort_by_file_name() ensures deterministic choice if multiple exist.
extensions.insert(dot_ext, relative_buf.clone());
extensions.insert(ext.to_string(), relative_buf);
}
}
}
}
Expand Down
Loading