refactor: Enhance code quality, CodeRabbit configuration and update pnpm lockfile

[yacosta738]

This pull request introduces several improvements and refactorings to the agent runtime, focusing on the DingTalk and iMessage channels, as well as some supporting configuration and documentation updates. The main goals are to modularize and simplify channel handling logic, improve error handling, and enhance maintainability.

Key changes include:

Channel Refactoring and Logic Improvements

• DingTalk Channel:

  • Extracted and modularized system frame handling and event callback logic into dedicated helper methods (build_pong_response, build_ack_response, extract_message_id, handle_system_frame, handle_event_callback), reducing code duplication and improving readability. [1] [2]
  • Simplified the main event loop by delegating message extraction and validation to these helpers, and centralized the acknowledgment logic.

• iMessage Channel:

  • Refactored database access logic into standalone async functions (find_messages_db, open_connection, fetch_initial_rowid, query_new_messages, create_channel_message) for better separation of concerns and easier testing.
  • Added a process_messages helper to streamline message filtering, validation, and dispatching, and encapsulated contact and message checks.
  • Simplified the listen loop by using the new helpers, improving clarity and reducing repeated code.

Dependency and Configuration Updates

• Rust Dependencies:

  • Added bytes and url crates to agent-runtime dependencies, preparing for HTTP streaming and URL handling needs. [1] [2]

• Check and Ignore Configs:

  • Updated .lycheeignore to include local favicon references for Vite apps, improving link checking accuracy in development environments.

Documentation and Quality

• SonarQube Issues Documentation:
  • Added a comprehensive SONARQUBE_ISSUES.md file summarizing code quality issues, severity, and a phased action plan for remediation, which will guide future technical debt reduction efforts.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (2)

• wip
• do-not-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

📝 Walkthrough

Walkthrough

This PR refactors multiple subsystems across the Rust backend and JavaScript frontend by extracting inline logic into modular helper functions. Changes span channel message handlers, configuration management, memory recall pipelines, HTTP tools, provider implementations, web UI components, and CLI commands—improving code organization without altering external APIs.

Changes

Cohort / File(s)	Summary
Configuration & Reporting .lycheeignore, SONARQUBE_ISSUES.md	Added favicon file patterns to lychee ignore list; added comprehensive SonarQube issues report documenting blockers, critical complexity, major, and minor findings with remediation plan.
Dependencies clients/agent-runtime/Cargo.toml	Added bytes and url crates for HTTP streaming and URL parsing.
Channel Handlers — Message Parsing clients/agent-runtime/src/channels/dingtalk.rs, imessage.rs, irc.rs, lark.rs, mattermost.rs, signal.rs, telegram.rs	Refactored message handling in all channels by extracting inline parsing, validation, and I/O logic into dedicated helpers. DingTalk: added frame handlers and ACK/pong responses. iMessage: added SQLite query helpers and message filtering. IRC: added registration, SASL, and PRIVMSG parsers. Lark: added locale and element extractors. Mattermost: added polling and post-processing helpers. Signal: added SSE handling pipeline. Telegram: large refactor with bind flow, chunked sends, Markdown fallback, and polling helpers. All maintain existing behavior via internal helpers.
Core Message Processing clients/agent-runtime/src/channels/mod.rs	Major refactor of process_channel_message: introduced ResponseContext, helper functions for history building, success/error/timeout handling, streaming setup, and task management. Unified canonical outcome handling with handle_canonical_blocking_outcome. Added draft updater and typing indicator task coordination.
Configuration Overrides clients/agent-runtime/src/config/schema.rs	Introduced eight environment-variable override helpers (env_override_string, env_override_port, env_override_bool, env_override_f64_clamped, env_override_usize_clamped, env_override_u64_positive, env_override_api_key_with_fallback) to centralize and validate env var parsing. Replaced inline override logic in apply_env_overrides with calls to the new helpers.
Memory Backends clients/agent-runtime/src/memory/sqlite.rs, surreal.rs	SQLite: added hybrid search combining BM25 and vector similarity via helper functions (hybrid_search, fetch_and_filter_entries, like_search). Surreal: introduced multi-stage recall pipeline with helpers (parse_query_terms, get_recall_candidates, generate_query_embedding, score_keyword_matches, score_vector_matches, fallback_search) replacing inline scoring and embedding logic.
Providers clients/agent-runtime/src/providers/anthropic.rs, compatible.rs, openai_codex.rs, reliable.rs	Anthropic: refactored per-message handling with process_message and message converters. Compatible: added SSE content extraction and streaming helpers. OpenAI Codex: added find_output_text_content and improved event parsing with extract_data_lines, parse_event_from_data. Reliable: introduced generic execute_with_fallback to centralize failover and retry logic.
Tools & Security clients/agent-runtime/src/tools/http_request.rs, security/policy.rs	HTTP: added header validation helpers (is_header_name_valid, is_header_value_valid, is_header_forbidden) and response header redaction. Security policy: introduced contains_blocked_operators, validate_command_segments, is_segment_valid, normalize_command helpers to replace inline validation blocks.
Gateway & Admin clients/agent-runtime/src/gateway/admin.rs, mod.rs	Admin: added input validation for memory_backend, webhook defaults, and host constraints. Gateway mod: introduced new public admin and utils modules; exposed AdminConfigUpdateRequest via admin namespace; exposed MockMemory and MockProvider for testing.
Cron & Diagnostics clients/agent-runtime/src/cron/scheduler.rs, doctor/mod.rs	Scheduler: extracted delivery and one-shot job handling into handle_delivery and handle_one_shot_job helpers. Doctor: introduced granular config validation helpers (check_provider_config, check_api_key_config, etc.) and separated daemon state handling into check_daemon_heartbeat, check_daemon_components.
CLI & Setup clients/agent-runtime/src/main.rs, onboard/wizard.rs	Main: extracted command handlers (handle_agent_command, handle_gateway_command, handle_daemon_command, handle_status_command) to modularize CLI dispatch. Wizard: large refactor introducing per-provider API-key helpers (setup_ollama_api_key, setup_gemini_api_key, etc.) and per-channel setup functions (setup_telegram_channel, setup_discord_channel, etc.) with centralized collect_api_key and per-channel flows.
Web Frontend — Chat App clients/web/apps/chat/index.html, package.json, src/App.vue, vite.config.js	Added favicon link, Vite config with Vue plugin and path aliases, and new dependencies (clsx, tailwind-merge). Refactored App.vue with pairing/save/chat error handlers (handlePairingError, handleSaveError, handleChatError), header builders (buildRequestHeaders), and message update helpers (updateAssistantMessage). Replaced inline SVG icons with external favicon references.
Web Frontend — Dashboard App clients/web/apps/dashboard/index.html, src/App.vue, vite.config.js	Added favicon link and Vite config. Refactored saveConfig flow with payload builders (buildConfigPayload, buildObservabilityPayload, buildAutonomyPayload, buildSchedulerPayload, buildGatewayPayload, buildWebhookPayload, buildSecretPayload), conflict handling, and unified save path via saveConfigToGateway. Added header logo UI with new CSS styling.
Web Frontend — Docs & Marketing clients/web/apps/docs/astro.config.mjs, marketing/src/pages/index.astro	Docs: added light/dark favicon references to Starlight logo config. Marketing: reformatted feature cards and testimonials; replaced inline brand span with image element.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• refactor(agent-loop): consolidate and unify runtime execution #123 — Unified agent-loop refactor with DispatchAction and channel/gateway wiring changes overlapping this PR's core message processing refactor.
• refactor: corvus env uppercase #18 — Environment-variable handling in config/schema.rs with CORVUS_* env names directly related to the env override helpers introduced here.
• feat: add basic chat UI with vue.js #24 — Dashboard web app frontend changes to App.vue and config files overlapping the same component refactoring.

Suggested labels

area:rust, area:docs, risk:security, risk:high

Suggested reviewers

• yuniel-acosta

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 23.40% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows Conventional Commit style with a 'refactor' prefix and clearly describes the main purpose of enhancing code quality and configuration.
Description check	✅ Passed	The description is comprehensive, covering related issues, a detailed summary of changes, and addressing the checklist items, though tested information section is minimal.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/code-improvements

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ Contributor Report

User: @yacosta738
Status: Passed (12/13 metrics passed)

Metric	Description	Value	Threshold	Status
PR Merge Rate	PRs merged vs closed	88%	>= 30%	✅
Repo Quality	Repos with ≥100 stars	0	>= 0	✅
Positive Reactions	Positive reactions received	9	>= 1	✅
Negative Reactions	Negative reactions received	0	<= 5	✅
Account Age	GitHub account age	3049 days	>= 30 days	✅
Activity Consistency	Regular activity over time	108%	>= 0%	✅
Issue Engagement	Issues with community engagement	0	>= 0	✅
Code Reviews	Code reviews given to others	385	>= 0	✅
Merger Diversity	Unique maintainers who merged PRs	2	>= 0	✅
Repo History Merge Rate	Merge rate in this repo	90%	>= 0%	✅
Repo History Min PRs	Previous PRs in this repo	95	>= 0	✅
Profile Completeness	Profile richness (bio, followers)	90	>= 0	✅
Suspicious Patterns	Spam-like activity detection	1	N/A	❌

---

_{Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-03-03 to 2026-03-03}

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud