feat: Centralize bootstrap wiring and introduce Agent Loop specification#167
Merged
yacosta738 merged 7 commits intoMar 8, 2026
Conversation
…me context Introduce a shared bootstrap module to construct observer/runtime/security/memory/tools once and reuse it across agent, channels, and gateway while preserving provider strategy per surface.
…and security requirements
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughIntroduces a shared BootstrapContext and factories to centralize provider, memory, runtime, observer, security, and tools wiring across agent, channels, and gateway; removes a SonarCloud coverage-gate relaxation step; expands .gitignore for agent backup artifacts; and adds two spec documents (agent-loop, MCP runtime). Changes
Sequence Diagram(s)sequenceDiagram
participant Config as Config
participant Bootstrap as BootstrapContext
participant Provider as Provider
participant Memory as Memory
participant Observer as Observer
participant Tools as Tools
participant Entry as Agent/Channels/Gateway
rect rgba(52,152,219,0.5)
Config->>Bootstrap: BootstrapContext::from_config(config)
Bootstrap-->>Provider: create_resilient_provider()/create_routed_provider()
Bootstrap-->>Memory: create_memory_and_observer()
Bootstrap-->>Observer: create_memory_and_observer()
Bootstrap-->>Tools: build tool registry
end
rect rgba(46,204,113,0.5)
Entry->>Bootstrap: request components
Bootstrap-->>Entry: return Provider, Memory, Observer, Tools
Entry->>Provider: warmup()/start
Entry->>Tools: describe/load
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-03-08 to 2026-03-08 |
Drop the workflow step that called SonarCloud quality gate update APIs at runtime, which was failing with curl exit code 22 and blocking analysis jobs.
Deploying corvus with
|
| Latest commit: |
4bac6c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://155be6ed.corvus-42x.pages.dev |
| Branch Preview URL: | https://feature-dallay-142-refactor.corvus-42x.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/agent-runtime/src/bootstrap/mod.rs`:
- Around line 120-127: The test currently asserts Arc::strong_count which is
meaningless for behavior; change it to assert the actual selected provider when
default_provider is None (i.e., that create_resilient_provider(&config) falls
back to the expected provider, e.g., "openrouter"). Locate the Config struct and
create_resilient_provider function, and update the test to either call a
provider API that exposes its identity (e.g., provider.name() or
provider.type()) or inject a test double/mock that records the chosen provider
name and assert that value equals the expected fallback; if the provider trait
lacks an identity method, add a small test-only accessor or use downcasting in
the test to verify the concrete provider type.
In `@clients/agent-runtime/src/channels/mod.rs`:
- Around line 1606-1616: start_channels currently advertises a separate
hand-maintained tool_descs list while the runtime uses bootstrap.tools, causing
divergent inventories; replace the manual tool_descs with descriptions derived
from the bootstrap registry returned by bootstrap::BootstrapContext::from_config
(or extend BootstrapContext to also expose preformatted prompt metadata) and use
the same Arc-wrapped bootstrap.tools instance (bootstrap.tools / tools_registry)
to build the prompt descriptions. Locate start_channels and remove the separate
tool_descs construction, iterate over bootstrap.tools (or its new exposed
metadata) to produce the prompt tool metadata, and ensure the same identifiers
and descriptions used by the runtime tools are serialized into the system prompt
so channels and agent/runtime remain in sync.
- Around line 1598-1606: The provider/bootstrap initialization
(create_resilient_provider, provider.warmup(), BootstrapContext::from_config)
should be moved so it runs only after confirming channels.is_empty() is false;
relocate the block to below the channels.is_empty() guard to preserve the
fast-path that returns early for empty configs, and ensure you add a regression
test that invokes the channel start path with an empty configuration to assert
it exits without performing network/bootstrap work or failing on provider
config.
In `@clients/agent-runtime/src/gateway/mod.rs`:
- Around line 1127-1129: Currently the gateway always calls
bootstrap::BootstrapContext::from_config which constructs memory and tools
(stored as _tools_registry) and later recreates an observer (lines ~1243-1245),
causing unnecessary MCP discovery and subprocess handles; change to a lighter
bootstrap path that only constructs and returns the pieces actually needed
(e.g., memory) or make a new function like
bootstrap::BootstrapContext::from_config_memory_only (or a lazy
BootstrapContext::from_config_lazy) so you avoid constructing tools unless they
are required (or gated by mcp-runtime feature/flag), or alternatively thread the
real BootstrapContext outputs into AppState and reuse them so tools/observer
aren’t redundantly constructed; update usages of BootstrapContext::from_config,
the local bindings memory and _tools_registry, and the later observer creation
to use the new lighter API or the shared AppState field.
In `@openspec/specs/agent-loop/spec.md`:
- Around line 11-27: The spec incorrectly states that gateway /webhook traffic
uses the canonical dispatcher and emits lifecycle stream events, but gateway
logic in clients/agent-runtime/src/gateway/mod.rs still performs canonical
pre-checks and handles requests via Provider::simple_chat(), so update the spec
to reflect current behavior: explicitly caveat that the gateway webhook is
handled via Provider::simple_chat() and does not yet route through the canonical
dispatcher or emit the described lifecycle events, or alternatively complete the
gateway migration in this PR by changing gateway/mod.rs to invoke the canonical
dispatcher boundary and emit the start/progress/completion stream events;
reference Provider::simple_chat() and gateway/mod.rs so reviewers can locate the
implementation to either align the docs or implement the migration.
In `@openspec/specs/mcp-runtime/spec.md`:
- Around line 93-117: The spec currently claims gateway parity for MCP approval
but the gateway webhook handler bypasses the shared approval pipeline by
prechecking canonical outcome and calling Provider::simple_chat(); either update
the spec text in spec.md to limit the "Entry-point parity for approval behavior"
requirement to the actual dispatcher entry points today (CLI and channel) or
change the gateway implementation so the /webhook handler stops prechecking and
instead routes MCP tool invocations into the shared approval/runtime pipeline
(remove the direct call to Provider::simple_chat() and invoke the same
policy/approval evaluators used by the other dispatchers), ensuring MCP tool
calls from the gateway undergo the same policy and approval checks and return
structured denial results when approval is not granted.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 63ebada2-f662-48d4-88db-de04c68598c7
📒 Files selected for processing (10)
.github/workflows/sonarqube-analysis.yml.gitignoreclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsopenspec/specs/agent-loop/spec.mdopenspec/specs/mcp-runtime/spec.md
💤 Files with no reviewable changes (1)
- .github/workflows/sonarqube-analysis.yml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: sonar
- GitHub Check: pr-checks
- GitHub Check: greet / Welcome first-time contributor
- GitHub Check: pr-checks
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (9)
clients/agent-runtime/src/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
clients/agent-runtime/src/**/*.rs: Never log secrets, tokens, raw credentials, or sensitive payloads in any logging statements
Avoid unnecessary allocations, clones, and blocking operations to maintain performance and efficiency
Files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
clients/agent-runtime/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Run
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warnings, andcargo testfor code validation, or document which checks were skipped and why
Files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
**/*.rs
⚙️ CodeRabbit configuration file
**/*.rs: Focus on Rust idioms, memory safety, and ownership/borrowing correctness.
Flag unnecessary clones, unchecked panics in production paths, and weak error context.
Prioritize unsafe blocks, FFI boundaries, concurrency races, and secret handling.
Files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsopenspec/specs/agent-loop/spec.mdopenspec/specs/mcp-runtime/spec.mdclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
clients/agent-runtime/src/main.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
clients/agent-runtime/src/main.rs: Preserve CLI contract unless change is intentional and documented; prefer explicit errors over silent fallback for unsupported critical paths
Keep startup path lean and avoid heavy initialization in command parsing flow
Files:
clients/agent-runtime/src/main.rs
clients/agent-runtime/src/channels/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Implement
Channeltrait insrc/channels/with consistentsend,listen, andhealth_checksemantics and cover auth/allowlist/health behavior with tests
Files:
clients/agent-runtime/src/channels/mod.rs
**/*.{md,mdx}
⚙️ CodeRabbit configuration file
**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes.
For user-facing docs, check EN/ES parity or explicitly note pending translation gaps.
Files:
openspec/specs/agent-loop/spec.mdopenspec/specs/mcp-runtime/spec.md
clients/agent-runtime/src/{security,gateway,tools}/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Treat
src/security/,src/gateway/,src/tools/as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks
Files:
clients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable
Files:
clients/agent-runtime/src/gateway/mod.rs
🧠 Learnings (15)
📓 Common learnings
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/channels/**/*.rs : Implement `Channel` trait in `src/channels/` with consistent `send`, `listen`, and `health_check` semantics and cover auth/allowlist/health behavior with tests
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/Cargo.toml : Do not add heavy dependencies for minor convenience; justify new crate additions
Applied to files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/providers/**/*.rs : Implement `Provider` trait in `src/providers/` and register in `src/providers/mod.rs` factory when adding a new provider
Applied to files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Preserve CLI contract unless change is intentional and documented; prefer explicit errors over silent fallback for unsupported critical paths
Applied to files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Keep startup path lean and avoid heavy initialization in command parsing flow
Applied to files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rsclients/agent-runtime/src/bootstrap/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/Cargo.toml : Preserve release-size profile assumptions in `Cargo.toml` and avoid adding heavy dependencies unless clearly justified
Applied to files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/*.rs : Run `cargo fmt --all -- --check`, `cargo clippy --all-targets -- -D warnings`, and `cargo test` for code validation, or document which checks were skipped and why
Applied to files:
clients/agent-runtime/src/lib.rsclients/agent-runtime/src/main.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/channels/**/*.rs : Implement `Channel` trait in `src/channels/` with consistent `send`, `listen`, and `health_check` semantics and cover auth/allowlist/health behavior with tests
Applied to files:
clients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs : Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable
Applied to files:
clients/agent-runtime/src/channels/mod.rsopenspec/specs/mcp-runtime/spec.mdclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rs
📚 Learning: 2026-02-17T07:28:38.934Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-02-17T07:28:38.934Z
Learning: Applies to .agents/AGENTS.md : Document agent configurations and capabilities in AGENTS.md
Applied to files:
openspec/specs/agent-loop/spec.md.gitignore
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/tools/**/*.rs : Implement `Tool` trait in `src/tools/` with strict parameter schema, validate and sanitize all inputs, and return structured `ToolResult` without panics in runtime path
Applied to files:
openspec/specs/mcp-runtime/spec.mdclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/agent/agent.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools}/**/*.rs : Treat `src/security/`, `src/gateway/`, `src/tools/` as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks
Applied to files:
clients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/**/*.rs : Avoid unnecessary allocations, clones, and blocking operations to maintain performance and efficiency
Applied to files:
clients/agent-runtime/src/agent/agent.rs
📚 Learning: 2026-02-17T07:28:38.934Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-02-17T07:28:38.934Z
Learning: Applies to .agents/AGENTS.md : Maintain comprehensive agent metadata including name, description, purpose, and capabilities
Applied to files:
.gitignore
📚 Learning: 2026-02-17T07:28:38.934Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-02-17T07:28:38.934Z
Learning: Applies to .agents/AGENTS.md : Include version information and compatibility details for agents
Applied to files:
.gitignore
🔇 Additional comments (1)
.gitignore (1)
165-210: LGTM — the backup ignore expansion looks safe.These entries consistently broaden ignore coverage for generated agent backup artifacts without introducing an obvious tracked-path regression in this block.
Validate provider fallback selection, preserve channels empty-config fast-path, derive channel prompt tool inventory from runtime registry, and avoid eager gateway tool bootstrap by reusing a memory+observer bootstrap path.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
clients/agent-runtime/src/bootstrap/mod.rs (1)
138-152:⚠️ Potential issue | 🟡 MinorAssert fallback selection directly instead of coupling this test to an auth-error path.
Lines 143-150 only pass if the current failure mode happens to mention
provider=openrouter. That keeps the test brittle and still doesn't prove the selection logic independently of provider initialization behavior. Since this module already importssuper::*, prefer asserting the selection helper directly or adding a small factory seam around the chosen provider name.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/agent-runtime/src/bootstrap/mod.rs` around lines 138 - 152, The test resilient_provider_uses_openrouter_when_default_provider_missing should assert the chosen fallback provider directly instead of relying on an auth error message; change the test to inspect the provider selection returned by create_resilient_provider(&config) (or add a small accessor/seam on the provider type that exposes the selected provider name, e.g., a provider_name() / inner enum) and assert it equals "openrouter" (or the corresponding enum variant) rather than matching err.to_string(); update the test to call that accessor or the selection helper from this module (super::select_provider or similar) to verify provider selection deterministically.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/agent-runtime/src/bootstrap/mod.rs`:
- Around line 90-104: The routed-provider path is not propagating
ProviderRuntimeOptions (e.g., corvus_dir and config.secrets.encrypt) which
causes routed setups to ignore runtime/secrets behavior; update the signature of
create_routed_provider (both in clients/agent-runtime/src/bootstrap/mod.rs and
the callee providers::create_routed_provider) to accept a ProviderRuntimeOptions
(or equivalent) and pass through config-derived options (corvus_dir and
config.secrets.encrypt) into providers::create_routed_provider and onward into
create_resilient_provider so the routed construction honors the same
runtime/secrets settings as the non-routed path.
In `@clients/agent-runtime/src/channels/mod.rs`:
- Around line 1724-1727: The code binds a local variable model using
config.default_model.unwrap_or_else(...) but uses a different literal fallback
("anthropic/claude-sonnet-4-20250514") than the other entry point that falls
back to "anthropic/claude-sonnet-4"; introduce a single shared constant (e.g.,
DEFAULT_MODEL = "anthropic/claude-sonnet-4") and replace the inline literal in
the model binding (the model variable that uses config.default_model) with
unwrap_or_else(|| DEFAULT_MODEL.into()), and update the other fallback site to
use the same DEFAULT_MODEL constant so both entry points use the exact same
shared default.
---
Duplicate comments:
In `@clients/agent-runtime/src/bootstrap/mod.rs`:
- Around line 138-152: The test
resilient_provider_uses_openrouter_when_default_provider_missing should assert
the chosen fallback provider directly instead of relying on an auth error
message; change the test to inspect the provider selection returned by
create_resilient_provider(&config) (or add a small accessor/seam on the provider
type that exposes the selected provider name, e.g., a provider_name() / inner
enum) and assert it equals "openrouter" (or the corresponding enum variant)
rather than matching err.to_string(); update the test to call that accessor or
the selection helper from this module (super::select_provider or similar) to
verify provider selection deterministically.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d2fa06b5-aa07-4838-bcb1-1b644832fe8c
📒 Files selected for processing (4)
clients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/tools/image_info.rs
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pr-checks
- GitHub Check: sonar
- GitHub Check: pr-checks
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (8)
clients/agent-runtime/src/tools/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Implement
Tooltrait insrc/tools/with strict parameter schema, validate and sanitize all inputs, and return structuredToolResultwithout panics in runtime path
Files:
clients/agent-runtime/src/tools/image_info.rs
clients/agent-runtime/src/{security,gateway,tools}/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Treat
src/security/,src/gateway/,src/tools/as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks
Files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/src/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
clients/agent-runtime/src/**/*.rs: Never log secrets, tokens, raw credentials, or sensitive payloads in any logging statements
Avoid unnecessary allocations, clones, and blocking operations to maintain performance and efficiency
Files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Run
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warnings, andcargo testfor code validation, or document which checks were skipped and why
Files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable
Files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/gateway/mod.rs
**/*.rs
⚙️ CodeRabbit configuration file
**/*.rs: Focus on Rust idioms, memory safety, and ownership/borrowing correctness.
Flag unnecessary clones, unchecked panics in production paths, and weak error context.
Prioritize unsafe blocks, FFI boundaries, concurrency races, and secret handling.
Files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/src/channels/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Implement
Channeltrait insrc/channels/with consistentsend,listen, andhealth_checksemantics and cover auth/allowlist/health behavior with tests
Files:
clients/agent-runtime/src/channels/mod.rs
🧠 Learnings (12)
📓 Common learnings
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/channels/**/*.rs : Implement `Channel` trait in `src/channels/` with consistent `send`, `listen`, and `health_check` semantics and cover auth/allowlist/health behavior with tests
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Preserve CLI contract unless change is intentional and documented; prefer explicit errors over silent fallback for unsupported critical paths
Applied to files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/*.rs : Run `cargo fmt --all -- --check`, `cargo clippy --all-targets -- -D warnings`, and `cargo test` for code validation, or document which checks were skipped and why
Applied to files:
clients/agent-runtime/src/tools/image_info.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/tools/**/*.rs : Implement `Tool` trait in `src/tools/` with strict parameter schema, validate and sanitize all inputs, and return structured `ToolResult` without panics in runtime path
Applied to files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/Cargo.toml : Preserve release-size profile assumptions in `Cargo.toml` and avoid adding heavy dependencies unless clearly justified
Applied to files:
clients/agent-runtime/src/tools/image_info.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/Cargo.toml : Do not add heavy dependencies for minor convenience; justify new crate additions
Applied to files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs : Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable
Applied to files:
clients/agent-runtime/src/tools/image_info.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/channels/**/*.rs : Implement `Channel` trait in `src/channels/` with consistent `send`, `listen`, and `health_check` semantics and cover auth/allowlist/health behavior with tests
Applied to files:
clients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Keep startup path lean and avoid heavy initialization in command parsing flow
Applied to files:
clients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/providers/**/*.rs : Implement `Provider` trait in `src/providers/` and register in `src/providers/mod.rs` factory when adding a new provider
Applied to files:
clients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools}/**/*.rs : Treat `src/security/`, `src/gateway/`, `src/tools/` as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks
Applied to files:
clients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/**/*.rs : Avoid unnecessary allocations, clones, and blocking operations to maintain performance and efficiency
Applied to files:
clients/agent-runtime/src/gateway/mod.rs
🔇 Additional comments (3)
clients/agent-runtime/src/tools/image_info.rs (1)
493-497: No concerns.This is a formatting-only rewrite of the same assertion; behavior stays unchanged.
clients/agent-runtime/src/gateway/mod.rs (1)
1121-1127: Good lightweight gateway bootstrap.This keeps provider selection centralized while avoiding the full tool bootstrap on gateway startup.
clients/agent-runtime/src/channels/mod.rs (1)
1883-1896: Good regression test for the empty-config fast path.Using an invalid provider here is a clean way to prove
start_channels()exits before any provider/bootstrap work.
Pass ProviderRuntimeOptions through routed provider construction so secrets/runtime settings match resilient mode, and unify channel/gateway default model fallback via shared bootstrap constant.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/agent-runtime/src/bootstrap/mod.rs`:
- Around line 34-46: BootstrapContext::from_config() duplicates observer and
memory initialization already done in create_memory_and_observer(), risking
drift; extract a single private helper (e.g., fn
init_memory_and_observer(config: &Config) -> anyhow::Result<(Arc<dyn Memory>,
Arc<dyn Observer>)>) that calls observability::create_observer(...) and
memory::create_memory(...)/config.api_key.as_deref() and returns the Arc-wrapped
values, then replace the duplicated wiring in BootstrapContext::from_config()
and in create_memory_and_observer() to call that helper so both paths share the
same initialization logic and error handling.
In `@clients/agent-runtime/src/channels/mod.rs`:
- Around line 1715-1730: The code currently constructs a resilient provider via
bootstrap::create_resilient_provider(&config) which bypasses route-specific
options; compute the default model first (using
BootstrapContext::from_config(&config) and config.default_model /
bootstrap::DEFAULT_MODEL) and then call
bootstrap::create_routed_provider(&config, &model) to obtain the Arc<dyn
Provider>, and keep calling provider.warmup().await on that routed provider;
replace the create_resilient_provider call with create_routed_provider(&config,
&model) and ensure types/signatures match so model_routes and routed
credentials/options are applied.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8cb003cd-8451-4d2f-ae73-20650fe4fad9
📒 Files selected for processing (4)
clients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/gateway/mod.rsclients/agent-runtime/src/providers/mod.rs
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pr-checks
- GitHub Check: sonar
- GitHub Check: pr-checks
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (8)
clients/agent-runtime/src/providers/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Implement
Providertrait insrc/providers/and register insrc/providers/mod.rsfactory when adding a new provider
Files:
clients/agent-runtime/src/providers/mod.rs
clients/agent-runtime/src/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
clients/agent-runtime/src/**/*.rs: Never log secrets, tokens, raw credentials, or sensitive payloads in any logging statements
Avoid unnecessary allocations, clones, and blocking operations to maintain performance and efficiency
Files:
clients/agent-runtime/src/providers/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Run
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warnings, andcargo testfor code validation, or document which checks were skipped and why
Files:
clients/agent-runtime/src/providers/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
**/*.rs
⚙️ CodeRabbit configuration file
**/*.rs: Focus on Rust idioms, memory safety, and ownership/borrowing correctness.
Flag unnecessary clones, unchecked panics in production paths, and weak error context.
Prioritize unsafe blocks, FFI boundaries, concurrency races, and secret handling.
Files:
clients/agent-runtime/src/providers/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/agent-runtime/src/providers/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/src/channels/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Implement
Channeltrait insrc/channels/with consistentsend,listen, andhealth_checksemantics and cover auth/allowlist/health behavior with tests
Files:
clients/agent-runtime/src/channels/mod.rs
clients/agent-runtime/src/{security,gateway,tools}/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Treat
src/security/,src/gateway/,src/tools/as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks
Files:
clients/agent-runtime/src/gateway/mod.rs
clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs
📄 CodeRabbit inference engine (clients/agent-runtime/AGENTS.md)
Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable
Files:
clients/agent-runtime/src/gateway/mod.rs
🧠 Learnings (11)
📓 Common learnings
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/providers/**/*.rs : Implement `Provider` trait in `src/providers/` and register in `src/providers/mod.rs` factory when adding a new provider
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/channels/**/*.rs : Implement `Channel` trait in `src/channels/` with consistent `send`, `listen`, and `health_check` semantics and cover auth/allowlist/health behavior with tests
Learnt from: CR
Repo: dallay/corvus PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-02-17T07:28:38.934Z
Learning: Applies to .agents/AGENTS.md : Document agent configurations and capabilities in AGENTS.md
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/providers/**/*.rs : Implement `Provider` trait in `src/providers/` and register in `src/providers/mod.rs` factory when adding a new provider
Applied to files:
clients/agent-runtime/src/providers/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Preserve CLI contract unless change is intentional and documented; prefer explicit errors over silent fallback for unsupported critical paths
Applied to files:
clients/agent-runtime/src/providers/mod.rsclients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/channels/**/*.rs : Implement `Channel` trait in `src/channels/` with consistent `send`, `listen`, and `health_check` semantics and cover auth/allowlist/health behavior with tests
Applied to files:
clients/agent-runtime/src/channels/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Keep startup path lean and avoid heavy initialization in command parsing flow
Applied to files:
clients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/tools/**/*.rs : Implement `Tool` trait in `src/tools/` with strict parameter schema, validate and sanitize all inputs, and return structured `ToolResult` without panics in runtime path
Applied to files:
clients/agent-runtime/src/channels/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs : Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable
Applied to files:
clients/agent-runtime/src/channels/mod.rsclients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools}/**/*.rs : Treat `src/security/`, `src/gateway/`, `src/tools/` as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks
Applied to files:
clients/agent-runtime/src/bootstrap/mod.rsclients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/*.rs : Run `cargo fmt --all -- --check`, `cargo clippy --all-targets -- -D warnings`, and `cargo test` for code validation, or document which checks were skipped and why
Applied to files:
clients/agent-runtime/src/bootstrap/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/**/*.rs : Avoid unnecessary allocations, clones, and blocking operations to maintain performance and efficiency
Applied to files:
clients/agent-runtime/src/gateway/mod.rs
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/**/Cargo.toml : Do not add heavy dependencies for minor convenience; justify new crate additions
Applied to files:
clients/agent-runtime/src/gateway/mod.rs
🔇 Additional comments (2)
clients/agent-runtime/src/gateway/mod.rs (2)
1121-1127: LGTM — lighter bootstrap path correctly adopted.The gateway now uses
create_memory_and_observerinstead of the fullBootstrapContext::from_config, which avoids constructing unused tools registry and MCP discovery overhead. This addresses the earlier review concern about unnecessary bootstrap work.Error propagation is correct via
?, and the sharedDEFAULT_MODELconstant ensures consistent fallback behavior across entry points.
11-14: Imports align with refactored initialization.The
bootstrapmodule import and updatedmemoryimports correctly support the centralized wiring changes.
…separate function
|
yacosta738
deleted the
feature/dallay-142-refactor-introduce-shared-bootstrapcontext-for
branch
This was referenced Mar 8, 2026
This was referenced Mar 18, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
bootstrapmodule to centralize and simplify the initialization of core agent components such as providers, memory, tools, and observer objects. The change removes duplicated setup logic from various entry points (agent, channels, gateway) and replaces it with calls to the shared bootstrap context. This improves maintainability, reduces code duplication, and ensures consistent initialization across the codebase.Key changes include:
Centralized Initialization (Bootstrap Module):
bootstrapmodule with aBootstrapContextstruct and helper functions to create providers and core agent components from aConfig. This module now handles the setup of observer, runtime, security, memory, and tools.agent.rs,channels/mod.rs, andgateway/mod.rsto use the new bootstrap context and provider creation helpers, removing duplicated setup logic and ensuring all entry points initialize components in a consistent way. [1] [2] [3] [4]Dependency Management and Imports:
bootstrapmodule and cleaned up unused or redundant imports. [1] [2] [3] [4] [5]Documentation:
openspec/specs/agent-loop/spec.mdto define the canonical agent loop behavior, requirements, and invariants across all entry points.These changes collectively improve the modularity and maintainability of the agent runtime by consolidating initialization logic and providing a clear contract for loop behavior and component setup.
Centralized Bootstrap Initialization
bootstrapmodule withBootstrapContextfor unified agent component setup, and helper functions for provider creation.agent.rs,channels/mod.rs, andgateway/mod.rsto use the new bootstrap context, eliminating duplicated initialization code. [1] [2] [3] [4]Dependency and Import Refactoring
bootstrapmodule and removed unnecessary imports in all affected files. [1] [2] [3] [4] [5]Documentation
openspec/specs/agent-loop/spec.mdto formally specify the agent loop contract, lifecycle, and security requirements.Closes: #160