feat(web): root docs locale and portless dev flow #192
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,8 +9,11 @@ const DEFAULT_PROD_URL = "https://docs.profiletailors.com"; | |
|
|
||
| const mode = process.env.NODE_ENV || "production"; | ||
| const env = loadEnv(mode, process.cwd(), ""); | ||
| const portlessUrl = | ||
| mode === "production" ? undefined : process.env.PORTLESS_URL ?? env.PORTLESS_URL; | ||
| const runtimeEnv = portlessUrl ? { ...env, DOCS_URL: portlessUrl } : env; | ||
| const docsUrl = resolveSiteUrl({ | ||
| env: runtimeEnv, | ||
| primaryKey: "DOCS_URL", | ||
| localDefault: DEFAULT_DEV_URL, | ||
| productionDefault: DEFAULT_PROD_URL, | ||
|
|
@@ -22,7 +25,11 @@ const docsUrl = resolveSiteUrl({ | |
| }, | ||
| isProdLike: mode === "production", | ||
| }); | ||
| const portCandidate = process.env.PORT ?? env.PORT; | ||
| const parsedPort = Number.parseInt(portCandidate ?? "", 10); | ||
| const resolvedPort = Number.isFinite(parsedPort) | ||
| ? parsedPort | ||
| : getPortFromUrl(docsUrl, PORTS.DOCS); | ||
|
|
||
| export default defineConfig({ | ||
| site: docsUrl, | ||
|
|
@@ -42,9 +49,9 @@ export default defineConfig({ | |
| light: "./public/favicon.svg", | ||
| dark: "./public/favicon-light.svg", | ||
| }, | ||
| defaultLocale: "root", | ||
| locales: { | ||
| root: { label: "English", lang: "en" }, | ||
| es: { label: "Español", lang: "es" }, | ||
| }, | ||
| plugins: [viewTransitions()], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,10 +3,10 @@ | |
| "type": "module", | ||
| "version": "0.4.0", | ||
| "scripts": { | ||
| "dev": "portless run --name docs astro dev", | ||
| "start": "portless run --name docs astro dev", | ||
| "build": "astro build", | ||
| "preview": "portless run --name docs astro preview", | ||
| "astro": "astro", | ||
| "format": "biome format --write src astro.config.mjs package.json tsconfig.json", | ||
| "lint": "biome lint src astro.config.mjs", | ||
|
|
@@ -21,6 +21,7 @@ | |
| "devDependencies": { | ||
| "@astrojs/check": "catalog:", | ||
| "astro-vtbot": "catalog:", | ||
| "portless": "catalog:", | ||
| "typescript": "catalog:", | ||
| "vite": "catalog:" | ||
| } | ||
|
|
||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -45,7 +45,7 @@ Contiene todas las aplicaciones cliente que consumen los módulos compartidos: | |||||||||||||||||||
|
|
||||||||||||||||||||
| ## El Directorio `docs` | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - **`docs/`**: Documentación en inglés (locale raíz). | ||||||||||||||||||||
| - `index.mdx`: Página de inicio. | ||||||||||||||||||||
| - `guides/`: Guías detalladas del proyecto. | ||||||||||||||||||||
| - **`docs/es/`**: Documentación en español. | ||||||||||||||||||||
|
Comment on lines
+48
to
+51
Contributor
There was a problem hiding this comment. Fix the Spanish locale paths. These entries still point to Suggested doc fix-- **`docs/`**: Documentación en inglés (locale raíz).
+- **`clients/web/apps/docs/src/content/docs/`**: Documentación en inglés (locale raíz).
- `index.mdx`: Página de inicio.
- `guides/`: Guías detalladas del proyecto.
-- **`docs/es/`**: Documentación en español.
+- **`clients/web/apps/docs/src/content/docs/es/`**: Documentación en español.As per coding guidelines, " 📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[grammar] ~49-~49: Elimina la puntuación (QB_NEW_ES_OTHER_ERROR_IDS_UNNECESSARY_PUNCTUATION) 🤖 Prompt for AI Agents |
||||||||||||||||||||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ Contains all client applications that consume the shared modules: | |
|
|
||
| ## Documentation | ||
|
|
||
| - **`clients/web/apps/docs/src/content/docs/`**: Documentation in English (root locale). | ||
| - `index.mdx`: Home page. | ||
| - `guides/`: Detailed project guides. | ||
| - **`clients/web/apps/docs/src/content/docs/es/`**: Documentation in Spanish. | ||
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ description: Welcome to the Corvus Agent Platform documentation. | |
|
|
||
| **Corvus** is a highly extensible, multi-interface agentic platform designed to bridge the gap between AI autonomy and human supervision. Built with a robust **Kotlin Multiplatform** foundation and powered by a high-performance **Rust** runtime, Corvus provides a secure, sandboxed environment for AI agents to perform complex, multi-step tasks. | ||
|
|
||
|  | ||
|
|
||
| ## ✨ Features | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| const { slug } = Astro.params; | ||
| const baseUrl = import.meta.env.BASE_URL.endsWith("/") | ||
| ? import.meta.env.BASE_URL.slice(0, -1) | ||
| : import.meta.env.BASE_URL; | ||
| Astro.redirect(`${baseUrl}${slug ? `/${slug}` : "/"}`); | ||
|
Comment on lines
+2
to
+6
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result: Yes. In Astro v5, a page must (And Sources: [1] Astro API reference ( Return the redirect response. This calls Minimal fix-Astro.redirect(`${baseUrl}${slug ? `/${slug}` : "/"}`);
+return Astro.redirect(`${baseUrl}${slug ? `/${slug}` : "/"}`);🤖 Prompt for AI Agents |
||
| --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,11 +23,15 @@ pnpm build:marketing | |
| pnpm --filter @corvus/marketing run check | ||
| ``` | ||
|
|
||
| Dev URL (portless): <http://marketing.localhost:1355> | ||
|
|
||
| Sin portless: `PORTLESS=0 pnpm dev:marketing` (usa `http://localhost:9988`). | ||
|
|
||
| ## Configuración de dominio y puerto | ||
|
|
||
| - Dev default: `http://marketing.localhost:1355` (portless) | ||
| - Prod default: `https://profiletailors.com` | ||
| - El puerto de `dev/preview` se toma de `PORT` (portless) o de `MARKETING_URL` si incluye puerto; si no, usa `9988` | ||
|
|
||
| Variable soportada: | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,11 +9,19 @@ const DEFAULT_PROD_URL = "https://profiletailors.com"; | |
| const mode = process.env.NODE_ENV || "production"; | ||
| const env = loadEnv(mode, process.cwd(), ""); | ||
|
|
||
| const portlessUrl = | ||
| mode === "production" | ||
| ? "" | ||
| : resolvePublicUrl(process.env.PORTLESS_URL ?? env.PORTLESS_URL, ""); | ||
| const marketingUrl = resolvePublicUrl( | ||
| env.MARKETING_URL ?? (portlessUrl || undefined), | ||
| mode === "production" ? DEFAULT_PROD_URL : DEFAULT_DEV_URL | ||
| ); | ||
| const portCandidate = process.env.PORT ?? env.PORT; | ||
| const parsedPort = Number.parseInt(portCandidate ?? "", 10); | ||
| const resolvedPort = Number.isFinite(parsedPort) | ||
| ? parsedPort | ||
| : getPortFromUrl(marketingUrl, PORTS.MARKETING); | ||
|
Comment on lines
+20
to
+24
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: # First, examine the actual file
cat -n clients/web/apps/marketing/astro.config.mjs | head -40Repository: dallay/corvus Length of output: 1530 🏁 Script executed: # Test Number.parseInt() behavior with the claimed problematic values
node <<'EOF'
console.log("Testing Number.parseInt() behavior:");
console.log("parseInt('123abc', 10):", Number.parseInt("123abc", 10));
console.log("parseInt('0', 10):", Number.parseInt("0", 10));
console.log("parseInt('70000', 10):", Number.parseInt("70000", 10));
console.log("parseInt('', 10):", Number.parseInt("", 10));
console.log("parseInt('abc', 10):", Number.parseInt("abc", 10));
console.log("");
console.log("isFinite() checks:");
console.log("isFinite(123):", Number.isFinite(123));
console.log("isFinite(NaN):", Number.isFinite(NaN));
console.log("isFinite(0):", Number.isFinite(0));
console.log("isFinite(70000):", Number.isFinite(70000));
console.log("");
console.log("isInteger() checks:");
console.log("isInteger(123):", Number.isInteger(123));
console.log("isInteger(0):", Number.isInteger(0));
console.log("isInteger(NaN):", Number.isInteger(NaN));
console.log("");
console.log("Port range validation [1..65535]:");
console.log("Valid port 80:", 80 >= 1 && 80 <= 65535);
console.log("Valid port 8080:", 8080 >= 1 && 8080 <= 65535);
console.log("Invalid port 0:", 0 >= 1 && 0 <= 65535);
console.log("Invalid port 65536:", 65536 >= 1 && 65536 <= 65535);
console.log("Invalid port 70000:", 70000 >= 1 && 70000 <= 65535);
EOFRepository: dallay/corvus Length of output: 552 🏁 Script executed: # Test the regex pattern from the diff suggestion
node <<'EOF'
const regex = /^(?:0|[1-9]\d{0,4})$/;
const testValues = ["0", "1", "80", "8080", "65535", "65536", "70000", "123abc", "abc", "", "00", "08", "99999"];
console.log("Testing regex /^(?:0|[1-9]\\d{0,4})$/:");
testValues.forEach(val => {
console.log(`"${val}": ${regex.test(val)}`);
});
EOFRepository: dallay/corvus Length of output: 257 Fix port validation—current regex in diff allows invalid ports beyond 65535. The issue is real: Use a strict range check instead: Corrected diff const portCandidate = process.env.PORT ?? env.PORT;
-const parsedPort = Number.parseInt(portCandidate ?? "", 10);
-const resolvedPort = Number.isFinite(parsedPort)
+const parsedPort = Number.parseInt(portCandidate ?? "", 10);
+const resolvedPort =
+ Number.isInteger(parsedPort) && parsedPort >= 1 && parsedPort <= 65535
? parsedPort
: getPortFromUrl(marketingUrl, PORTS.MARKETING);🤖 Prompt for AI Agents |
||
|
|
||
| export default defineConfig({ | ||
| site: marketingUrl, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,12 +6,12 @@ | |
| "type": "module", | ||
| "scripts": { | ||
| "copy-install": "bash -c 'if [ -f ../../../../scripts/install.sh ]; then cp ../../../../scripts/install.sh public/install; else echo \"scripts/install.sh not found; skipping copy\"; fi'", | ||
| "dev": "portless run --name marketing astro dev", | ||
| "predev": "pnpm run copy-install", | ||
| "start": "portless run --name marketing astro dev", | ||
| "build": "astro build", | ||
| "prebuild": "pnpm run copy-install", | ||
| "preview": "portless run --name marketing astro preview", | ||
| "astro": "astro", | ||
| "format": "biome format --write src public package.json astro.config.mjs tsconfig.json README.md", | ||
| "check": "biome check src public package.json astro.config.mjs tsconfig.json README.md", | ||
|
|
@@ -23,6 +23,7 @@ | |
| "sharp": "catalog:" | ||
| }, | ||
| "devDependencies": { | ||
| "portless": "catalog:", | ||
| "typescript": "catalog:", | ||
| "vite": "catalog:" | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: dallay/corvus
Length of output: 674
🏁 Script executed:
fd -t f -i 'readme*' clients/web/apps/chatRepository: dallay/corvus
Length of output: 88
🏁 Script executed:
git ls-files clients/web/apps/chat | grep -i readmeRepository: dallay/corvus
Length of output: 88
🌐 Web query:
portless PORTLESS=0 environment variable fallback behavior vite💡 Result:
portlesshas a built-in “escape hatch” env var:PORTLESS=0(orPORTLESS=skip), portless bypasses the proxy entirely and just runs your command normally (no named.localhostURL, no proxy auto-start, and no portless port/host injection). [1]PORT/HOST; because Vite ignoresPORT, portless instead auto-injects--portand--hostwhen it is enabled. [1]PORTLESS=0, that injection doesn’t happen, so Vite falls back to its normal behavior (default dev port, and if that port is taken it will try the next available port). [2]Example
PORTLESS=0 pnpm dev # runs plain `vite` (or whatever your dev script runs), no proxySources: portless configuration docs [1]; Vite server option docs (port fallback) [2].
🏁 Script executed:
Repository: dallay/corvus
Length of output: 956
Fix port fallback for
PORTLESS=0legacy mode.The
--port 4323flag was removed from the vite commands, andvite.config.tsdoes not specifyserver.port. WhenPORTLESS=0is set, portless bypasses entirely and Vite falls back to port 5173 instead of the documented 4323.Add
server: { port: 4323 }tovite.config.tsto preserve the README contract: "UsePORTLESS=0 pnpm dev:chatto run on http://localhost:4323".🤖 Prompt for AI Agents