chore(.github): apply Spotless formatting fixes to copilot-instructions.md#20
Conversation
|
Thank you for contributing to this project with this PR, welcome to the community and the amazing world of open source! |
📝 WalkthroughWalkthroughA new Markdown document added to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-02-17 to 2026-02-17 |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/copilot-instructions.md (2)
139-139: Add language specification to code block.The fenced code block should specify a language for better markdown compliance and consistent rendering. Consider using
textorplaintext.♻️ Proposed fix
-``` +```text ├── apps/ │ ├── composeApp/ # Shared Kotlin Multiplatform Compose UI module🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/copilot-instructions.md at line 139, The fenced code block currently uses plain triple backticks without a language hint; update the opening fence from ``` to ```text (or ```plaintext) so the block is language-specified (e.g., change ``` to ```text before the tree snippet lines starting with "├── apps/"). Ensure the closing fence remains ``` and no other content is changed.
21-25: Remove extra spaces after blockquote symbols.Lines 21-25 have multiple spaces after the
>symbol, which violates markdown standards. Use a single space for consistency.♻️ Proposed fix for blockquote spacing
-> 2. **Extreme Performance Second** - Optimize for efficiency after security -> - Think about algorithmic complexity (O(n) vs O(n²)) -> - Avoid unnecessary allocations -> - Use lazy initialization when appropriate -> - Profile before optimizing - measure don't guess -> - Consider memory footprint and startup time +> 2. **Extreme Performance Second** - Optimize for efficiency after security +> - Think about algorithmic complexity (O(n) vs O(n²)) +> - Avoid unnecessary allocations +> - Use lazy initialization when appropriate +> - Profile before optimizing - measure don't guess +> - Consider memory footprint and startup time🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/copilot-instructions.md around lines 21 - 25, The blockquote lines starting with ">" shown in the diff have multiple spaces after the ">"—replace the extra spaces with a single space for each blockquote (e.g., change "> - Think..." to "> - Think...") to conform to markdown style; update all affected blockquote items in .github/copilot-instructions.md so every ">" is followed by exactly one space and ensure consistency across similar list items.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/copilot-instructions.md:
- Around line 15-18: The four security principle lines are indented but missing
the blockquote prefix, breaking the Markdown blockquote; update those lines (the
bullets "Use parameterized queries, never string concatenation for SQL",
"Validate and sanitize all data", "Follow principle of least privilege", and
"Keep dependencies updated to patch security vulnerabilities") to include the
leading ">" so they belong to the surrounding blockquote (or alternatively
un-indent them to move them outside the blockquote) to restore consistent
formatting.
---
Nitpick comments:
In @.github/copilot-instructions.md:
- Line 139: The fenced code block currently uses plain triple backticks without
a language hint; update the opening fence from ``` to ```text (or ```plaintext)
so the block is language-specified (e.g., change ``` to ```text before the tree
snippet lines starting with "├── apps/"). Ensure the closing fence remains ```
and no other content is changed.
- Around line 21-25: The blockquote lines starting with ">" shown in the diff
have multiple spaces after the ">"—replace the extra spaces with a single space
for each blockquote (e.g., change "> - Think..." to "> - Think...") to
conform to markdown style; update all affected blockquote items in
.github/copilot-instructions.md so every ">" is followed by exactly one space
and ensure consistency across similar list items.
| - Use parameterized queries, never string concatenation for SQL | ||
| - Validate and sanitize all data | ||
| - Follow principle of least privilege | ||
| - Keep dependencies updated to patch security vulnerabilities |
There was a problem hiding this comment.
Fix blockquote formatting inconsistency.
These security principle lines are indented but lack the > blockquote prefix, breaking the blockquote structure. They should either be part of the blockquote (with > prefix) or unindented to be outside it.
📝 Proposed fix to include lines in blockquote
-> - Use parameterized queries, never string concatenation for SQL
-> - Validate and sanitize all data
-> - Follow principle of least privilege
-> - Keep dependencies updated to patch security vulnerabilities
+> - Use parameterized queries, never string concatenation for SQL
+> - Validate and sanitize all data
+> - Follow principle of least privilege
+> - Keep dependencies updated to patch security vulnerabilities🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/copilot-instructions.md around lines 15 - 18, The four security
principle lines are indented but missing the blockquote prefix, breaking the
Markdown blockquote; update those lines (the bullets "Use parameterized queries,
never string concatenation for SQL", "Validate and sanitize all data", "Follow
principle of least privilege", and "Keep dependencies updated to patch security
vulnerabilities") to include the leading ">" so they belong to the surrounding
blockquote (or alternatively un-indent them to move them outside the blockquote)
to restore consistent formatting.
This pull request introduces a new set of agent instructions for the repository, focusing on security-first and performance-second principles, and provides comprehensive guidelines for development, testing, and project structure. Additionally, it makes minor formatting adjustments to the branch protection ruleset configuration.
Documentation and Guidelines:
.github/copilot-instructions.mdfile that details core development principles (security and performance), quick commands for building and testing, code style conventions, Gradle best practices, project structure, available skills, and testing patterns.Configuration Formatting:
includearray forref_nameand theallowed_merge_methodsarray in.github/rulesets/main-protection.jsonto use single-line array formatting for improved readability and consistency. [1] [2]Summary by CodeRabbit