fix(marketing): remove /en prefix from docs links to fix 404 errors#281
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoved Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-03-20 to 2026-03-20 |
Deploying corvus with
|
| Latest commit: |
c5768e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e89ea5fd.corvus-42x.pages.dev |
| Branch Preview URL: | https://fix-marketing-docs-links.corvus-42x.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts (2)
7-7: 🧹 Nitpick | 🔵 TrivialUnused variable
isCiafter refactor.
isCiis defined but no longer referenced. Remove the dead code.-val isCi = providers.environmentVariable("CI").orNull?.isNotBlank() == true🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts` at line 7, Remove the dead variable by deleting the unused declaration val isCi from the Gradle Kotlin script; locate the declaration of isCi in the build-logic script and remove that single line (the providers.environmentVariable(...) assignment) so there are no unused local variables left after the refactor.
26-43:⚠️ Potential issue | 🟡 MinorPipeline failure: detekt ReturnCount violation.
shouldUseDependencyLockinghas 4 return statements, exceeding the limit of 2. Refactor to reduce early returns.♻️ Proposed fix to consolidate returns
fun Configuration.shouldUseDependencyLocking(): Boolean { - if (!isCanBeResolved) { - return false - } - - if (name in excludedLockingConfigurations) { - return false - } - - if ( - project.rootProject.name == "corvus-build-logic" && - name in buildLogicOnlyExcludedLockingConfigurations - ) { - return false - } - - return excludedLockingConfigurationPrefixes.none { prefix -> name.startsWith(prefix) } + val isBuildLogicExcluded = + project.rootProject.name == "corvus-build-logic" && + name in buildLogicOnlyExcludedLockingConfigurations + + return isCanBeResolved && + name !in excludedLockingConfigurations && + !isBuildLogicExcluded && + excludedLockingConfigurationPrefixes.none { prefix -> name.startsWith(prefix) } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts` around lines 26 - 43, The function shouldUseDependencyLocking currently has multiple early returns; refactor it to compute a single Boolean result and return once to satisfy Detekt's ReturnCount rule. Replace the early-return checks (isCanBeResolved, name in excludedLockingConfigurations, the rootProject/name check against buildLogicOnlyExcludedLockingConfigurations, and the excludedLockingConfigurationPrefixes.none check) by evaluating them into a single val (e.g., val shouldUse = ...) using logical operators and then return that val at the end; reference the existing symbols shouldUseDependencyLocking, isCanBeResolved, excludedLockingConfigurations, project.rootProject.name, buildLogicOnlyExcludedLockingConfigurations, and excludedLockingConfigurationPrefixes to locate the conditions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@gradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.kts`:
- Line 64: Remove the unused variable declaration "isCI" introduced by val isCI
= EnvAccess.isCi(providers) since it is not referenced anywhere; delete that
line (or replace its usage with a direct call where needed) to avoid dead code
and confusion, ensuring no other code references the symbol "isCI".
In
`@gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts`:
- Line 54: The change removed strict dependency lock enforcement in the locking
build logic—restore or explicitly enforce LockMode.STRICT: update the
dependencyLocking configuration (the dependencyLocking block and
ignoredDependencies usage) to set LockMode.STRICT again, or add a clear guard
that ensures LockMode.STRICT is applied at CI/root level (matching
com.profiletailors.check.dependencies.gradle.kts) so strict lock enforcement
remains guaranteed for supply-chain integrity.
---
Outside diff comments:
In
`@gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts`:
- Line 7: Remove the dead variable by deleting the unused declaration val isCi
from the Gradle Kotlin script; locate the declaration of isCi in the build-logic
script and remove that single line (the providers.environmentVariable(...)
assignment) so there are no unused local variables left after the refactor.
- Around line 26-43: The function shouldUseDependencyLocking currently has
multiple early returns; refactor it to compute a single Boolean result and
return once to satisfy Detekt's ReturnCount rule. Replace the early-return
checks (isCanBeResolved, name in excludedLockingConfigurations, the
rootProject/name check against buildLogicOnlyExcludedLockingConfigurations, and
the excludedLockingConfigurationPrefixes.none check) by evaluating them into a
single val (e.g., val shouldUse = ...) using logical operators and then return
that val at the end; reference the existing symbols shouldUseDependencyLocking,
isCanBeResolved, excludedLockingConfigurations, project.rootProject.name,
buildLogicOnlyExcludedLockingConfigurations, and
excludedLockingConfigurationPrefixes to locate the conditions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 05643e30-61a5-4a7b-860a-e443a88abd00
📒 Files selected for processing (4)
clients/web/apps/docs/src/content/docs/es/guides/cerebro/mcp-schema/mem_suggest_topic_key.jsonclients/web/apps/docs/src/content/docs/es/guides/cerebro/mcp-schema/mem_update.jsongradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.ktsgradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: pr-checks-build-logic
- GitHub Check: core-checks
- GitHub Check: sonar
- GitHub Check: pr-checks
- GitHub Check: pr-checks-build-logic
- GitHub Check: submit-gradle
- GitHub Check: core-checks
- GitHub Check: pr-checks
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (2)
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/web/apps/docs/src/content/docs/es/guides/cerebro/mcp-schema/mem_suggest_topic_key.jsongradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.ktsclients/web/apps/docs/src/content/docs/es/guides/cerebro/mcp-schema/mem_update.jsongradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.kts
**/*.gradle.kts
⚙️ CodeRabbit configuration file
**/*.gradle.kts: Prefer tasks.register/configureEach, avoid afterEvaluate, and preserve configuration cache.
Ensure dependencies come from version catalogs and avoid eager task realization.
Review plugin/config changes for supply-chain and reproducibility risks.
Files:
gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.ktsgradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.kts
🪛 GitHub Actions: Scan with Detekt
gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts
[error] 26-26: detekt ReturnCount: Function shouldUseDependencyLocking has 4 return statements (limit: 2).
🔇 Additional comments (3)
clients/web/apps/docs/src/content/docs/es/guides/cerebro/mcp-schema/mem_suggest_topic_key.json (1)
44-44: Formatting-only change is safe.EOF newline addition has no behavioral, schema, or security impact.
clients/web/apps/docs/src/content/docs/es/guides/cerebro/mcp-schema/mem_update.json (1)
16-21: No behavioral change detected inanyOftyping.This hunk is formatting-only; schema validation behavior and accepted
observationtypes are unchanged.gradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.kts (1)
67-67: RemovingLockMode.STRICTin CI weakens reproducibility guarantees.Previously, CI enforced strict lock mode, failing builds when dependencies drifted from the lockfile. Without this, lockfile mismatches may go undetected in CI, which is a supply-chain risk per coding guidelines. If strict enforcement moved elsewhere (e.g., the
checkLockstask), please confirm; otherwise, consider restoring CI-specific strict mode.[raise_major_issue, request_verification]
#!/bin/bash # Verify if LockMode.STRICT is configured elsewhere in build-logic rg -n "LockMode\.STRICT" gradle/build-logic/
There was a problem hiding this comment.
♻️ Duplicate comments (1)
gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts (1)
44-44:⚠️ Potential issue | 🟠 MajorSame placeholder
com.example:*pattern found here.This duplicates the issue in the sibling script. If this is intentional configuration, use the actual dependency coordinates; otherwise remove.
The
LockMode.STRICTremoval concern was already raised in a previous review. Ensure strict lock enforcement is handled elsewhere or restore it to maintain supply-chain integrity.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts` at line 44, The dependencyLocking block uses a placeholder ignored dependency pattern "com.example:*" which duplicates the sibling script; replace this placeholder with the actual group:artifact coordinates to ignore or remove the ignoredDependencies.add("com.example:*") call if no ignore is needed, and verify that LockMode.STRICT enforcement is configured elsewhere (or restore LockMode.STRICT) so strict lock enforcement for dependency locking remains in place; look for the dependencyLocking block and any use of ignoredDependencies and LockMode.STRICT to make the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts`:
- Line 44: The dependencyLocking block uses a placeholder ignored dependency
pattern "com.example:*" which duplicates the sibling script; replace this
placeholder with the actual group:artifact coordinates to ignore or remove the
ignoredDependencies.add("com.example:*") call if no ignore is needed, and verify
that LockMode.STRICT enforcement is configured elsewhere (or restore
LockMode.STRICT) so strict lock enforcement for dependency locking remains in
place; look for the dependencyLocking block and any use of ignoredDependencies
and LockMode.STRICT to make the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4b0b773b-35ff-41d2-b114-2d6a4b0f7e9b
📒 Files selected for processing (2)
gradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.ktsgradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: submit-gradle
- GitHub Check: pr-checks-build-logic
- GitHub Check: pr-checks
- GitHub Check: core-checks
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (2)
**/*.gradle.kts
⚙️ CodeRabbit configuration file
**/*.gradle.kts: Prefer tasks.register/configureEach, avoid afterEvaluate, and preserve configuration cache.
Ensure dependencies come from version catalogs and avoid eager task realization.
Review plugin/config changes for supply-chain and reproducibility risks.
Files:
gradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.ktsgradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
gradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.ktsgradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts
🔇 Additional comments (2)
gradle/build-logic/src/main/kotlin/com.profiletailors.check.locking.gradle.kts (1)
25-32: LGTM on the refactored exclusion logic.The combined predicate properly handles build-logic-specific exclusions. The logic is clear: exclude configurations that aren't resolvable, are in the global exclusion set, match build-logic-only exclusions when in that project, or start with excluded prefixes.
gradle/build-logic/src/main/kotlin/com.profiletailors.check.dependencies.gradle.kts (1)
64-64: Remove placeholder dependency patterncom.example:*from build logic.This pattern appears in newly created build files (
com.profiletailors.check.dependencies.gradle.ktsandcom.profiletailors.check.locking.gradle.kts) but uses the standard documentation placeholder namespace. Either replace with the actual dependency to ignore or remove if not needed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
1 participant
This pull request updates several documentation links on the marketing homepage to remove the
/en/language prefix from their URLs. This ensures that all references to guides and documentation point to the correct, language-agnostic paths.Documentation Link Updates:
index.astroto remove the/en/prefix, ensuring links now use the format${docsBaseUrl}/guides/...instead of${docsBaseUrl}/en/guides/.... This change affects install guides, CLI references, architecture docs, and quick start links throughout the install methods, quick links, FAQ groups, and hero panel. [1] [2] [3] [4] [5] [6] [7] [8] [9]