Skip to content

fix(docs): repair broken local links#399

Merged
yacosta738 merged 2 commits into
mainfrom
feature/dallay-211-docs-broken-links-report
Apr 3, 2026
Merged

fix(docs): repair broken local links#399
yacosta738 merged 2 commits into
mainfrom
feature/dallay-211-docs-broken-links-report

Conversation

@yacosta738
Copy link
Copy Markdown
Contributor

Restore valid local docs references and CSS imports so the offline link checker stops flagging false broken paths in the Corvus docs surfaces.

Restore valid local docs references and CSS imports so the offline link checker stops flagging false broken paths in the Corvus docs surfaces.
@linear
Copy link
Copy Markdown

linear Bot commented Apr 3, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Warning

Rate limit exceeded

@yacosta738 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 54 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 54 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8eb6452d-2cc3-48d2-8cdd-088e50ef5a36

📥 Commits

Reviewing files that changed from the base of the PR and between f560f8c and 08b964a.

📒 Files selected for processing (1)
  • clients/web/packages/shared/app-shell.css
📝 Walkthrough

Walkthrough

This PR updates documentation link paths throughout the codebase and converts CSS @import syntax from url(...) format to direct string imports across multiple style sheets and documentation files.

Changes

Cohort / File(s) Summary
Documentation Path Updates
clients/agent-runtime/README.md, modules/cerebro/README.md
Updated Cerebro migration guide references from guides/cerebro/migration.md to cerebro/migration.md in documentation link targets.
CSS Import Syntax Modernization
clients/web/apps/chat/src/style.css, clients/web/apps/dashboard/src/style.css, clients/web/apps/docs/src/styles/custom.css, clients/web/apps/marketing/src/styles/global.css
Converted CSS @import declarations from url("...") syntax to direct string imports for shared design tokens and Tailwind CSS.
Documentation Content Links (Agent-Runtime Tools)
clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/core.md, clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx, clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/*.md
Updated internal documentation links to reference architecture.md#security-model and architecture.md#runtime instead of configuration.md guides.
Shared Tokens Asset
clients/web/packages/shared/tokens.css
Added new entry point file that imports theme definitions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

area:docs, area:web

Suggested reviewers

  • yuniel-acosta
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive Description is brief but vague about what was actually fixed. Required sections from template like Related Issues, Tested Information, and Documentation Impact are missing or incomplete. Expand description to specify which broken links were fixed, list exact documentation paths updated, and describe testing approach for verifying the fixes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title uses correct Conventional Commit format (fix prefix), is clear and imperative, and accurately describes the main change: repairing broken documentation links.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/dallay-211-docs-broken-links-report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

✅ Contributor Report

User: @yacosta738
Status: Passed (12/13 metrics passed)

Metric Description Value Threshold Status
PR Merge Rate PRs merged vs closed 89% >= 30%
Repo Quality Repos with ≥100 stars 0 >= 0
Positive Reactions Positive reactions received 10 >= 1
Negative Reactions Negative reactions received 0 <= 5
Account Age GitHub account age 3079 days >= 30 days
Activity Consistency Regular activity over time 108% >= 0%
Issue Engagement Issues with community engagement 0 >= 0
Code Reviews Code reviews given to others 503 >= 0
Merger Diversity Unique maintainers who merged PRs 2 >= 0
Repo History Merge Rate Merge rate in this repo 91% >= 0%
Repo History Min PRs Previous PRs in this repo 194 >= 0
Profile Completeness Profile richness (bio, followers) 90 >= 0
Suspicious Patterns Spam-like activity detection 1 N/A

Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-04-03 to 2026-04-03

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@clients/web/apps/dashboard/src/style.css`:
- Around line 1-2: The import syntax is inconsistent: style.css uses bare-string
imports (`@import` "@corvus/shared/app-shell.css";) while the imported
app-shell.css still uses `@import` url("..."); — update the import statements in
app-shell.css to use the same bare-string syntax (e.g., `@import` "..." ) so both
files use the consistent form; ensure any occurrences of url("...") at the top
of app-shell.css that reference internal CSS modules are converted to the
bare-string `@import` "module-path" style to match the changed pattern.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 580b412e-3d17-415a-a772-d079046b7ffd

📥 Commits

Reviewing files that changed from the base of the PR and between b8d994e and f560f8c.

📒 Files selected for processing (11)
  • clients/agent-runtime/README.md
  • clients/web/apps/chat/src/style.css
  • clients/web/apps/dashboard/src/style.css
  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/core.md
  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx
  • clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/core.md
  • clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/index.mdx
  • clients/web/apps/docs/src/styles/custom.css
  • clients/web/apps/marketing/src/styles/global.css
  • clients/web/packages/shared/tokens.css
  • modules/cerebro/README.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: pr-checks
  • GitHub Check: sonar
  • GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (2)
**/*

⚙️ CodeRabbit configuration file

**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.

Files:

  • clients/web/packages/shared/tokens.css
  • clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/core.md
  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx
  • clients/web/apps/chat/src/style.css
  • clients/web/apps/dashboard/src/style.css
  • modules/cerebro/README.md
  • clients/web/apps/marketing/src/styles/global.css
  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/core.md
  • clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/index.mdx
  • clients/web/apps/docs/src/styles/custom.css
  • clients/agent-runtime/README.md
**/*.{md,mdx}

⚙️ CodeRabbit configuration file

**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes.
For user-facing docs, check EN/ES parity or explicitly note pending translation gaps.

Files:

  • clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/core.md
  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx
  • modules/cerebro/README.md
  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/core.md
  • clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/index.mdx
  • clients/agent-runtime/README.md
🧠 Learnings (4)
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools,config}/**/*.rs : Do not silently weaken security policy or access constraints; keep default behavior secure-by-default with deny-by-default where applicable

Applied to files:

  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/tools/**/*.rs : Implement `Tool` trait in `src/tools/` with strict parameter schema, validate and sanitize all inputs, and return structured `ToolResult` without panics in runtime path

Applied to files:

  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/{security,gateway,tools}/**/*.rs : Treat `src/security/`, `src/gateway/`, `src/tools/` as high-risk surfaces and never broaden filesystem/network execution scope without explicit policy checks

Applied to files:

  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/src/main.rs : Preserve CLI contract unless change is intentional and documented; prefer explicit errors over silent fallback for unsupported critical paths

Applied to files:

  • clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/core.md
  • clients/agent-runtime/README.md
🔇 Additional comments (11)
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/core.md (1)

20-20: Valid relative link fix for Runtime section.

Line 20 correctly points to a sibling architecture.md anchor and matches the corresponding English docs structure.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes. For user-facing docs, check EN/ES parity or explicitly note pending translation gaps."

clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/tools/index.mdx (1)

15-15: Security model link update looks correct.

Line 15 now targets the architecture security-model section with a valid relative path and preserves ES/EN parity for this reference.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes. For user-facing docs, check EN/ES parity or explicitly note pending translation gaps."

clients/agent-runtime/README.md (2)

102-102: Build-from-source migration link path is corrected and consistent.

Line 102 uses a valid repo-relative location for the migration guide in the new docs location.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes."


389-389: Docs section now points to the same corrected migration target.

Line 389 matches the updated migration-guide path, eliminating drift between README sections.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes."

modules/cerebro/README.md (1)

21-21: Integration migration link fix is good.

Line 21 correctly reflects the new migration-guide location and aligns with the related README updates.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes."

clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/core.md (1)

18-18: Runtime link target correction is accurate.

Line 18 now uses the correct relative jump to the architecture runtime anchor and stays in sync with the ES docs update.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes. For user-facing docs, check EN/ES parity or explicitly note pending translation gaps."

clients/web/apps/docs/src/content/docs/clients/agent-runtime/tools/index.mdx (1)

15-15: Deny-by-default security link now points to the right section.

Line 15 correctly references the architecture security-model anchor with a valid relative path and preserves EN/ES docs parity.
As per coding guidelines "**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes. For user-facing docs, check EN/ES parity or explicitly note pending translation gaps."

clients/web/apps/marketing/src/styles/global.css (1)

1-2: Syntax changes look correct.

The updated @import syntax is valid CSS. Build tool compatibility verification requested in clients/web/apps/dashboard/src/style.css applies here as well.

clients/web/apps/chat/src/style.css (1)

1-2: Syntax changes look correct.

The updated @import syntax is valid CSS. Build tool compatibility verification requested in clients/web/apps/dashboard/src/style.css applies here as well.

clients/web/apps/docs/src/styles/custom.css (1)

7-8: Syntax changes look correct.

The updated @import syntax is valid CSS. Build tool compatibility verification requested in clients/web/apps/dashboard/src/style.css applies here as well.

clients/web/packages/shared/tokens.css (1)

1-1: tokens.css is a documented compatibility alias during the rename to theme.css—no consolidation needed.

The file is explicitly an alias (./tokens.css./theme.css per package.json), as noted in the README. App-shell.css already imports theme.css, and no consumers currently import tokens.css directly, so there is no actual duplicate import risk. The temporary dual import in tokens.css is intentional during the transition period.

Comment on lines +1 to +2
@import "@corvus/shared/app-shell.css";
@import "tailwindcss";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the import syntax is consistent and check build configuration

# Check if other CSS files use the old url() syntax
echo "=== Checking for remaining url() syntax in `@import` statements ==="
rg -n '@import\s+url\(' --type=css clients/web/

# Look for build tool configuration that might affect CSS import handling
echo -e "\n=== Checking build configuration files ==="
fd -e config.js -e config.ts -e json --exec echo "File: {}" \; --exec rg -l 'css|style' {} \;

# Check package.json for CSS/style related dependencies
echo -e "\n=== Checking CSS-related build dependencies ==="
fd package.json clients/web/ --exec jq -r '.devDependencies | keys[] | select(test("css|style|vite|webpack|postcss"))' {} \;

Repository: dallay/corvus

Length of output: 5792


Ensure consistent @import syntax across CSS files that import each other.

Both @import "..." and @import url("...") syntaxes are valid and supported by Vite and PostCSS. However, the changed file in style.css now uses the bare string syntax while clients/web/packages/shared/app-shell.css (which it imports) still uses url() syntax. For maintainability, align the syntax in app-shell.css to match the new pattern.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@clients/web/apps/dashboard/src/style.css` around lines 1 - 2, The import
syntax is inconsistent: style.css uses bare-string imports (`@import`
"@corvus/shared/app-shell.css";) while the imported app-shell.css still uses
`@import` url("..."); — update the import statements in app-shell.css to use the
same bare-string syntax (e.g., `@import` "..." ) so both files use the consistent
form; ensure any occurrences of url("...") at the top of app-shell.css that
reference internal CSS modules are converted to the bare-string `@import`
"module-path" style to match the changed pattern.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 3, 2026

Deploying corvus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08b964a
Status: ✅  Deploy successful!
Preview URL: https://f4b42c5e.corvus-42x.pages.dev
Branch Preview URL: https://feature-dallay-211-docs-brok.corvus-42x.pages.dev

View logs

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

@yacosta738 yacosta738 merged commit ee07750 into main Apr 3, 2026
14 checks passed
@yacosta738 yacosta738 deleted the feature/dallay-211-docs-broken-links-report branch April 3, 2026 11:28
@yacosta738 yacosta738 mentioned this pull request Apr 3, 2026
This was referenced Apr 11, 2026
@dallay-bot dallay-bot Bot mentioned this pull request May 3, 2026
@dallay-bot dallay-bot Bot mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant