fix(release): harden release-please diagnostics#451
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🧰 Additional context used📓 Path-based instructions (1)**/*⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📓 Common learnings🔇 Additional comments (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded an explicit checkout step after the release-please action so repository metadata (e.g., .release-please-manifest.json) is available before the summary step. Added English and Spanish governance guidance requiring release-automation changes via pull request and allowing direct Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-04-07 to 2026-04-07 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/release-contract.test.mjs`:
- Around line 130-133: Add an assertion that verifies the Spanish docs (docsEs)
contain the governance wording equivalent to the English check (docsEn).
Specifically, in the test that already asserts docsEn for "through a pull
request", add an assert.match on docsEs for the Spanish governance phrase (use
the correct localized wording present in docsEs) so that the governance rule
parity is enforced; update the same test block that references
docsEn/docsEs/changelog.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9a88d429-e084-4fe6-b8ef-66e328cd0079
📒 Files selected for processing (5)
.github/workflows/README.md.github/workflows/release-please.ymlclients/web/apps/docs/src/content/docs/es/guides/release.mdclients/web/apps/docs/src/content/docs/guides/release.mdscripts/release-contract.test.mjs
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: pr-checks
- GitHub Check: sonar
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{md,mdx}
⚙️ CodeRabbit configuration file
**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes.
For user-facing docs, check EN/ES parity or explicitly note pending translation gaps.
Files:
clients/web/apps/docs/src/content/docs/es/guides/release.mdclients/web/apps/docs/src/content/docs/guides/release.md
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/web/apps/docs/src/content/docs/es/guides/release.mdclients/web/apps/docs/src/content/docs/guides/release.mdscripts/release-contract.test.mjs
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Follow `.github/pull_request_template.md` and keep PR descriptions concrete with problem, change, non-goals, risk, and rollback information
📚 Learning: 2026-02-17T12:31:17.076Z
Learnt from: CR
Repo: dallay/corvus PR: 0
File: clients/agent-runtime/AGENTS.md:0-0
Timestamp: 2026-02-17T12:31:17.076Z
Learning: Applies to clients/agent-runtime/.github/**/*.{yml,yaml} : For workflow/template-only changes, ensure YAML/template syntax validity
Applied to files:
.github/workflows/README.md
🔇 Additional comments (5)
clients/web/apps/docs/src/content/docs/guides/release.md (1)
74-79: LGTM — governance rules are clear and well-aligned with workflow changes.The three-point governance rule correctly documents the PR-based workflow, emergency-only direct push policy, and short-lived branch repair pattern. Contract tests in
release-contract.test.mjsverify this wording.clients/web/apps/docs/src/content/docs/es/guides/release.md (1)
74-79: LGTM — Spanish translation maintains parity with English governance rules.Translation is semantically accurate and uses appropriate terminology ("rama corta" for short-lived branch, "protección de rama" for branch protection).
.github/workflows/release-please.yml (1)
32-37: LGTM — checkout step correctly ensures manifest availability for diagnostics.SHA-pinned action, shallow clone, and
always()condition are appropriate here. The step runs even on release-please failure, which is exactly what's needed for reliable diagnostics output..github/workflows/README.md (1)
251-259: LGTM — README documentation accurately reflects workflow changes and governance policy.The new checkout step documentation and governance note are consistent with the actual workflow implementation and the release runbook.
scripts/release-contract.test.mjs (1)
74-74: LGTM — contract test correctly verifies the new checkout step exists.
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Deploying corvus with
|
| Latest commit: |
4bcb1be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54b13248.corvus-42x.pages.dev |
| Branch Preview URL: | https://fix-release-please-summary-p.corvus-42x.pages.dev |
|
1 participant
This pull request introduces improvements to the release automation workflow and documentation, emphasizing stricter governance and reliability. The main changes ensure that release automation changes follow a pull request process, enhance workflow diagnostics reliability, and update related tests and documentation in both English and Spanish.
Governance and process improvements:
clients/web/apps/docs/src/content/docs/guides/release.md,clients/web/apps/docs/src/content/docs/es/guides/release.md) requiring that changes to release automation must go through a pull request, reserving direct pushes tomainfor emergencies only, and outlining the procedure for fixing broken release infrastructure. [1] [2].github/workflows/README.md)Workflow reliability:
release-please.ymlworkflow to explicitly check out repository metadata before summarizing the workflow outcome, preventing diagnostics from failing due to missing manifest files. (.github/workflows/release-please.yml)Test updates:
scripts/release-contract.test.mjs) [1] [2]