fix: clarify Cerebro constants, fix Spanish heading, remove circular spec ref, explicit ceiling, improve shell docs#509
Merged
Conversation
…t ceiling, improve docs Agent-Logs-Url: https://github.com/dallay/corvus/sessions/222dc495-1d96-418f-a84e-614863ff188e Co-authored-by: yacosta738 <33158051+yacosta738@users.noreply.github.com>
Deploying corvus with
|
| Latest commit: |
cda6d10
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acc4aec7.corvus-42x.pages.dev |
| Branch Preview URL: | https://copilot-fix-tools-constant-l.corvus-42x.pages.dev |
Agent-Logs-Url: https://github.com/dallay/corvus/sessions/222dc495-1d96-418f-a84e-614863ff188e Co-authored-by: yacosta738 <33158051+yacosta738@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tools constant listing for clarity and availability
fix: clarify Cerebro constants, fix Spanish heading, remove circular spec ref, explicit ceiling, improve shell docs
Apr 11, 2026
yacosta738
approved these changes
Apr 11, 2026
|
This was referenced Apr 11, 2026
Merged
This was referenced Apr 19, 2026
Closed
This was referenced Apr 28, 2026
Merged
8 tasks
8 tasks
8 tasks
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes several documentation clarity and spec correctness issues across four files: ambiguous constant relationships in
normalize.rs, a mistranslated section heading, a circular spec cross-reference, an implicit ceiling value, and under-documented shell functions.Changes
clients/agent-runtime/src/tools/mcp/normalize.rsCEREBRO_GATEWAY_ALLOWLIST(superset for routing/classification) andCEREBRO_PLANNED_TOOLS(planned-only subset), explicitly notingmem_contextis excluded from the planned list because it is considered availableclients/web/apps/docs/src/content/docs/es/guides/release.mdDiagnósticos que debes revisar→Diagnósticos a revisar durante un Releaseto match the objective tone and specificity of the English headingopenspec/specs/runtime-image-pipeline/spec.md(see REQ-8)from themax_image_bytesvalidation paragraph — REQ-8 does not contain these rules, making the reference circular/misleadingwithin the supported ceiling→less than or equal to 8formax_images_per_turn— eliminates the need for cross-spec lookupscripts/check-tools.shprint_statuswith a full structured docstring (parameters + return values)numeric_prefixRelated Issues
Summary
Multiple small clarity and correctness fixes: constant relationship documentation in the Rust MCP normalize module, a Spanish translation tone mismatch, two spec ambiguities (circular reference and implicit ceiling value), and improved shell function documentation with extracted reusable helpers.
Tested Information
tools::mcp::normalizepass with no changes to test logicbash -nsyntax check confirmscheck-tools.shis validDocumentation Impact
clients/web/apps/docs/src/content/docs/es/guides/release.mdopenspec/specs/runtime-image-pipeline/spec.mdclients/agent-runtime/src/tools/mcp/normalize.rsandscripts/check-tools.shBreaking Changes
None.
Checklist
Original prompt