feat(agent-runtime): Phase 5A — trait compliance macros and differential tests#515
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-04-11 to 2026-04-11 |
1d275b3 to
0d513b3
Compare
Deploying corvus with
|
| Latest commit: |
1d275b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c584da15.corvus-42x.pages.dev |
| Branch Preview URL: | https://feature-dallay-264-phase-5a.corvus-42x.pages.dev |
20c0527
into
feature/capability-architecture
Related Issues
Closes DALLAY-264
Summary
Phase 5A introduces the trait compliance test harness for the capability-based architecture. This PR delivers:
Five
#[macro_export]compliance macros incrates/corvus-traits/src/testing.rs, replacing the 6-lineTraitHarnessplaceholder:provider_compliance_tests!— validatescapabilities(),chat_with_system(),supports_streaming(),convert_tools()tool_compliance_tests!— validatesname(),description(),execute()memory_compliance_tests!— validatesname(),health_check(),count()channel_compliance_tests!— validatesname(),health_check()sandbox_compliance_tests!— validatesname(),is_available()Each macro takes a factory expression and generates standard test functions. Self-validation tests using stub implementations are included in
#[cfg(test)].pub mod testing— thetestingmodule is now public so capability crates (corvus-providers,corvus-channels, etc.) can import and use the macros.Six differential tests in
crates/corvus-composer/src/lib.rsthat validateAgentComposer::required_capabilities()is consistent with each manifest section (providers, channels, tools, memory presence/absence).Tested Information
Results:
corvus-traits: 22 → 37 tests (15 new: 5 macros × 3 self-tests each)corvus-composer: 8 → 14 tests (6 new differential tests)Documentation Impact
docs/composing-agents.mdadded in Phase 5B covers the user-facing documentation.Breaking Changes
None. The
testingmodule visibility change (mod→pub mod) is additive — no existing code referenced the private module.Checklist