fix(docs): remove trailing slashes from internal links#523
Conversation
- Remove trailing slashes from relative links in getting-started.md and release.md - Add note about missing architecture diagrams (moved to separate repo) - Fix Spanish getting-started links (no separate sub-pages exist in Spanish version) Fixes internal 404 links in built docs.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughDocumentation updates: normalized several relative links (removed trailing slashes), consolidated Spanish “Next Steps” links into an English-only note, marked architecture C4 diagrams as unavailable and replaced diagram paths with placeholders, and adjusted session sidebar active-item styling (CSS only). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying corvus with
|
| Latest commit: |
7f6ebaf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe47777d.corvus-42x.pages.dev |
| Branch Preview URL: | https://feature-code-agent-capabilit.corvus-42x.pages.dev |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-04-13 to 2026-04-13 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
clients/web/apps/docs/src/content/docs/guides/architecture/overview.md (3)
63-63:⚠️ Potential issue | 🟡 MinorExample paths may be outdated.
If the system context and container diagrams moved to the separate repository (per lines 20-21, 27), these example paths will fail. Update the examples to reflect the actual location of diagram files, or clarify that these are hypothetical examples.
Also applies to: 72-72
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md` at line 63, The example command "mmdc -i diagrams/context/system-context.mmd -o context.png" uses paths that may be outdated; update the example paths to the repository that now contains the diagrams (or to their new folder names) or add a short parenthetical note that these are hypothetical/example paths and may need adjusting—also apply the same change to the other example at the second occurrence (the command around line 72). Locate and update the example command strings in the document (e.g., the two instances of the mmdc -i ... system-context.mmd command) to either point to the correct diagram repository/file locations or annotate them as illustrative only.
1-9: 🧹 Nitpick | 🔵 TrivialNote: Missing Spanish translation.
Per coding guidelines for documentation, EN/ES parity should be verified. No Spanish version of this architecture overview appears to exist (unlike the getting-started and release guides which have ES versions). Consider whether this architectural documentation should be translated to maintain consistency across the documentation set.
As per coding guidelines: "For user-facing docs, check EN/ES parity or explicitly note pending translation gaps."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md` around lines 1 - 9, The Architecture Overview document (title: "Architecture Overview") lacks an ES translation; either add a Spanish counterpart with the same frontmatter keys and translated content (create a file alongside the existing one using the same metadata with Spanish text and owner/status/etc.), or explicitly mark the doc as pending translation by adding a clear frontmatter flag (e.g., translations: es: pending) and a short in-doc note stating the ES version is forthcoming to satisfy EN/ES parity checks; update whichever you choose consistently across the doc metadata and top of the markdown body.
35-35:⚠️ Potential issue | 🟠 MajorRemove or restore broken diagram file references.
Verification shows that the diagram files referenced at lines 35 and 43 (
./diagrams/component/runtime-core.mmdand./diagrams/cargo-dependencies.mmd) do not exist in the repository. These references must be either removed to align with the documented migration to a separate repository, or restored if these diagrams should remain local.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md` at line 35, The markdown references to missing diagram files (`./diagrams/component/runtime-core.mmd` and `./diagrams/cargo-dependencies.mmd`) in overview.md are broken; either remove those two file links or restore the diagrams into the repo (or replace each with an external repository URL) so links resolve. Edit overview.md to locate the references to `component/runtime-core.mmd` and `cargo-dependencies.mmd` and either delete those link lines, swap them for correct external links to the separate diagrams repo, or add the missing .mmd files into the diagrams folder to restore the original links.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/web/apps/docs/src/content/docs/es/guides/getting-started.md`:
- Line 116: Revert the English-only sentence replacement in the ES guide and
either provide an accurate Spanish translation for "All sections (Project
Structure, Features, Development) are covered in this page. Continue reading
above for details." or explicitly mark the EN/ES navigation gap (e.g., add a
short Spanish note like "Traducción pendiente; consulte la versión EN para más
detalles" and a link to the EN page). Update the "Project Structure",
"Features", and "Development" headings in this file to ensure they are present
in Spanish or clearly flagged as pending so readers know which sub-pages are
untranslated.
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md`:
- Around line 20-21: The markdown contains a broken link titled "Corvus
Architecture Diagrams" pointing to
https://github.com/dallay/corvus/tree/main/docs/architecture/diagrams; update
that link target to the correct GitHub repository/path if available or remove
the sentence and link entirely (or replace it with a plain note that the
diagrams repo is not yet available) so the page no longer references a 404 URL.
- Line 27: The note text "Container diagram source files are in the architecture
diagrams repository." is missing a direct GitHub link; update that note to
include the same (or a more specific) GitHub URL used earlier in Level 1 so
users can jump directly to the container diagrams repository—edit the markdown
line containing that note to append or replace with a full hyperlink to the
repository (matching the style of the Level 1 link for consistency).
---
Outside diff comments:
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md`:
- Line 63: The example command "mmdc -i diagrams/context/system-context.mmd -o
context.png" uses paths that may be outdated; update the example paths to the
repository that now contains the diagrams (or to their new folder names) or add
a short parenthetical note that these are hypothetical/example paths and may
need adjusting—also apply the same change to the other example at the second
occurrence (the command around line 72). Locate and update the example command
strings in the document (e.g., the two instances of the mmdc -i ...
system-context.mmd command) to either point to the correct diagram
repository/file locations or annotate them as illustrative only.
- Around line 1-9: The Architecture Overview document (title: "Architecture
Overview") lacks an ES translation; either add a Spanish counterpart with the
same frontmatter keys and translated content (create a file alongside the
existing one using the same metadata with Spanish text and owner/status/etc.),
or explicitly mark the doc as pending translation by adding a clear frontmatter
flag (e.g., translations: es: pending) and a short in-doc note stating the ES
version is forthcoming to satisfy EN/ES parity checks; update whichever you
choose consistently across the doc metadata and top of the markdown body.
- Line 35: The markdown references to missing diagram files
(`./diagrams/component/runtime-core.mmd` and
`./diagrams/cargo-dependencies.mmd`) in overview.md are broken; either remove
those two file links or restore the diagrams into the repo (or replace each with
an external repository URL) so links resolve. Edit overview.md to locate the
references to `component/runtime-core.mmd` and `cargo-dependencies.mmd` and
either delete those link lines, swap them for correct external links to the
separate diagrams repo, or add the missing .mmd files into the diagrams folder
to restore the original links.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 116399ff-9deb-4228-8139-155e4c41147d
📒 Files selected for processing (5)
clients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/es/guides/release.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.mdclients/web/apps/docs/src/content/docs/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/release.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: report / Contributor Quality Report
- GitHub Check: sonar
- GitHub Check: pr-checks
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: submit-gradle
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{md,mdx}
⚙️ CodeRabbit configuration file
**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes.
For user-facing docs, check EN/ES parity or explicitly note pending translation gaps.
Files:
clients/web/apps/docs/src/content/docs/es/guides/release.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.mdclients/web/apps/docs/src/content/docs/guides/release.mdclients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/getting-started.md
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/web/apps/docs/src/content/docs/es/guides/release.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.mdclients/web/apps/docs/src/content/docs/guides/release.mdclients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/getting-started.md
🔇 Additional comments (3)
clients/web/apps/docs/src/content/docs/guides/release.md (1)
219-219: Trailing-slash cleanup looks correct.This relative link normalization is consistent with the docs cleanup and should avoid duplicate path variants.
clients/web/apps/docs/src/content/docs/es/guides/release.md (1)
219-219: Cambio correcto en enlace relativo.La eliminación de la barra final mantiene consistencia con la guía en inglés y evita variantes de ruta innecesarias.
clients/web/apps/docs/src/content/docs/guides/getting-started.md (1)
112-114: Next-steps link updates are clean and consistent.Removing trailing slashes here is a good normalization with no behavioral risk in doc intent.
| - [`container/runtime-containers.puml`](./diagrams/container/runtime-containers.puml) (PlantUML) | ||
| - **Description**: Shows the runtime containers: CLI, gateway, daemon services, tool execution, | ||
| memory backends, and operator surfaces around Corvus. | ||
| > **Note**: Container diagram source files are in the architecture diagrams repository. |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Add a specific link for consistency.
Level 1 (line 21) includes a specific GitHub link, but this Level 2 note omits it. For better UX, include the same or a more specific link to the container diagrams.
📝 Suggested improvement
-> **Note**: Container diagram source files are in the architecture diagrams repository.
+> **Note**: Container diagram source files are managed in a separate repository.
+ See the [Corvus Architecture Diagrams](https://github.com/dallay/corvus/tree/main/docs/architecture/diagrams) for source files.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| > **Note**: Container diagram source files are in the architecture diagrams repository. | |
| > **Note**: Container diagram source files are managed in a separate repository. | |
| See the [Corvus Architecture Diagrams](https://github.com/dallay/corvus/tree/main/docs/architecture/diagrams) for source files. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md` at
line 27, The note text "Container diagram source files are in the architecture
diagrams repository." is missing a direct GitHub link; update that note to
include the same (or a more specific) GitHub URL used earlier in Level 1 so
users can jump directly to the container diagrams repository—edit the markdown
line containing that note to append or replace with a full hyperlink to the
repository (matching the style of the Level 1 link for consistency).
- Replace English text with Spanish note in ES getting-started - Fix broken GitHub links in architecture overview (now plain notes) - Remove broken .mmd file references (add pending migration notes) - Fix example command paths (note they're illustrative) - Add translations.es: pending frontmatter flag
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
clients/web/apps/docs/src/content/docs/guides/architecture/overview.md (1)
44-87:⚠️ Potential issue | 🟠 MajorDocument structure misaligned with actual content.
The "How to Visualize" (lines 44-71), "Conventions" (lines 73-78), and "Maintenance" (lines 80-87) sections provide detailed guidance for viewing and maintaining diagrams, but all actual diagrams have been removed and replaced with migration notes. This creates a documentation gap where the structure promises content that isn't delivered.
Consider either:
- Temporarily remove or collapse these sections until diagrams are available in the new repository, then restore them with updated paths
- Add a prominent note at the top stating the diagrams are in migration and these sections will apply once migration completes
- Update these sections to reference the new repository location once available
As per coding guidelines, docs must "stay aligned with code changes" and maintain technical accuracy.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md` around lines 44 - 87, The "How to Visualize", "Conventions", and "Maintenance" sections promise diagrams that have been removed; update the document to avoid misleading readers by either (a) temporarily collapsing or removing these sections until diagrams are migrated, (b) adding a prominent migration notice at the top of the page stating that diagrams are being moved and that the guidance under "How to Visualize", "Conventions", and "Maintenance" will apply after migration, or (c) updating the instructions to point to the new repository/location once available; locate and edit the headings "How to Visualize", "Conventions", and "Maintenance" in this file to implement one of these options and ensure the page remains accurate with the current repo state.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/web/apps/docs/src/content/docs/es/guides/getting-started.md`:
- Around line 116-117: The link labeled '[versión en inglés](./getting-started)'
incorrectly points back to the Spanish page; update that link target to the
actual English guide file (replace './getting-started' with the correct relative
path to the English guide, i.e. the en/guides/getting-started page) so the note
links to the English version of the Getting Started guide.
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md`:
- Line 22: Replace the four placeholder migration notes that read "Architecture
diagrams are currently being migrated to a separate repository." (occurrences at
the notes currently shown) with actionable content: add the target repo URL (or
a "TBD" repo link if not yet public), a short migration timeline/ETA, and a
temporary alternative link or path to the old diagram location (or instructions
on how to request access); update the note text to include this information and
make sure all four occurrences use the same phrasing and links so users can find
the C4 diagrams while migration completes.
- Around line 60-61: Replace the hardcoded example filenames in the diagram
render commands so they don't reference non-existent artifacts: update
occurrences of "<path-to-diagram>/system-context.mmd" and
"<path-to-diagram>/runtime-containers.puml" (and the associated command examples
like "mmdc -i <path-to-diagram>/system-context.mmd -o context.png") to use a
generic example name such as "<path-to-diagram>/example-diagram.mmd" (or remove
the specific filename entirely and show a placeholder like
"<path-to-diagram>/<diagram-file>"), and make the same change for the other
command block to avoid implying those exact files must exist.
---
Outside diff comments:
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md`:
- Around line 44-87: The "How to Visualize", "Conventions", and "Maintenance"
sections promise diagrams that have been removed; update the document to avoid
misleading readers by either (a) temporarily collapsing or removing these
sections until diagrams are migrated, (b) adding a prominent migration notice at
the top of the page stating that diagrams are being moved and that the guidance
under "How to Visualize", "Conventions", and "Maintenance" will apply after
migration, or (c) updating the instructions to point to the new
repository/location once available; locate and edit the headings "How to
Visualize", "Conventions", and "Maintenance" in this file to implement one of
these options and ensure the page remains accurate with the current repo state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0cf92364-4721-4fb2-b30d-fa7f2720c63f
📒 Files selected for processing (2)
clients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: sonar
- GitHub Check: submit-gradle
- GitHub Check: report / Contributor Quality Report
- GitHub Check: pr-checks
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{md,mdx}
⚙️ CodeRabbit configuration file
**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes.
For user-facing docs, check EN/ES parity or explicitly note pending translation gaps.
Files:
clients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.md
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.md
🔇 Additional comments (1)
clients/web/apps/docs/src/content/docs/guides/architecture/overview.md (1)
9-10: LGTM: Translation gap properly noted.The frontmatter correctly marks Spanish translations as pending. As per coding guidelines, user-facing docs should "explicitly note pending translation gaps."
- SessionSidebar: fix active item visibility in dark mode (bg-raised + red accent) - ES getting-started: fix link to English guide (/es/guides -> /guides) - Architecture overview: add migration notice, generic placeholder filenames, notes on unavailable sections
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
clients/web/apps/docs/src/content/docs/guides/architecture/overview.md (1)
3-3:⚠️ Potential issue | 🟡 MinorUpdate the description to reflect current state.
The description claims this is a "Collection of C4 diagrams" but the page content states diagrams are "temporarily unavailable." This misleads users who expect to find actual diagrams.
📝 Suggested improvement
-description: Collection of C4 diagrams for the Corvus project +description: Architecture overview and C4 diagram documentation for the Corvus project (diagrams pending migration)As per coding guidelines, verify technical accuracy and that docs stay aligned with code changes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md` at line 3, Update the front-matter description field in overview.md: replace the misleading "Collection of C4 diagrams for the Corvus project" with a current, accurate summary such as "Architecture overview — diagrams temporarily unavailable" (or similar) so the description matches the page content that states diagrams are temporarily unavailable; locate and edit the YAML 'description' key in the file to make this change.
♻️ Duplicate comments (1)
clients/web/apps/docs/src/content/docs/es/guides/getting-started.md (1)
117-117:⚠️ Potential issue | 🟠 MajorFix relative link path to English guide on line 117.
The link
../guides/getting-startedresolves toes/guides/getting-startedinstead of the English version. Change to../../guides/getting-startedto correctly point todocs/guides/getting-started.md.Diff
> Consulte la [versión en inglés](../guides/getting-started) para más detalles. +> Consulte la [versión en inglés](../../guides/getting-started) para más detalles.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/guides/getting-started.md` at line 117, Update the relative link on the Spanish guide line that reads "../guides/getting-started" to use one more parent segment so it becomes "../../guides/getting-started", ensuring the reference in the document (the link text "Consulte la [versión en inglés](../guides/getting-started) ...") points to the English guide at docs/guides/getting-started.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/web/apps/docs/src/content/docs/es/guides/getting-started.md`:
- Line 116: The Spanish note contains English section names ("Project Structure,
Features y Development"); update the sentence to either translate those names
into Spanish (e.g., "Estructura del proyecto, Funcionalidades y Desarrollo") or
mark the English terms as foreign by italicizing them (e.g., *Project
Structure*, *Features* y *Development*) so readers understand they refer to
EN-only sections—locate the sentence containing "Project Structure, Features y
Development" in getting-started.md and apply the chosen change.
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md`:
- Line 16: Update the GitHub issues link text "Track progress at
https://github.com/dallay/corvus/issues (tag: architecture-diagrams)" so it
includes the label filter parameter for direct filtering (e.g., append
?q=is%3Aissue+label%3Aarchitecture-diagrams or use
/issues?q=label%3Aarchitecture-diagrams); edit the line in overview.md
containing that sentence and replace the raw repository issues URL with the
filtered URL so users land directly on issues tagged "architecture-diagrams".
---
Outside diff comments:
In `@clients/web/apps/docs/src/content/docs/guides/architecture/overview.md`:
- Line 3: Update the front-matter description field in overview.md: replace the
misleading "Collection of C4 diagrams for the Corvus project" with a current,
accurate summary such as "Architecture overview — diagrams temporarily
unavailable" (or similar) so the description matches the page content that
states diagrams are temporarily unavailable; locate and edit the YAML
'description' key in the file to make this change.
---
Duplicate comments:
In `@clients/web/apps/docs/src/content/docs/es/guides/getting-started.md`:
- Line 117: Update the relative link on the Spanish guide line that reads
"../guides/getting-started" to use one more parent segment so it becomes
"../../guides/getting-started", ensuring the reference in the document (the link
text "Consulte la [versión en inglés](../guides/getting-started) ...") points to
the English guide at docs/guides/getting-started.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2a5ec7c9-ce05-43a6-aa02-6cfcfe2d9082
📒 Files selected for processing (3)
clients/web/apps/dashboard/src/components/chat/SessionSidebar.vueclients/web/apps/docs/src/content/docs/es/guides/getting-started.mdclients/web/apps/docs/src/content/docs/guides/architecture/overview.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: report / Contributor Quality Report
- GitHub Check: sonar
- GitHub Check: pr-checks
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (python)
- GitHub Check: submit-gradle
- GitHub Check: Cloudflare Pages
🧰 Additional context used
📓 Path-based instructions (3)
**/*.vue
⚙️ CodeRabbit configuration file
**/*.vue: Enforce Vue 3 Composition API with <script setup>.
Ensure accessibility (A11y) and proper use of Tailwind CSS classes.
Check for proper prop validation and emitted events documentation.
Files:
clients/web/apps/dashboard/src/components/chat/SessionSidebar.vue
**/*
⚙️ CodeRabbit configuration file
**/*: Security first, performance second.
Validate input boundaries, auth/authz implications, and secret management.
Look for behavioral regressions, missing tests, and contract breaks across modules.
Files:
clients/web/apps/dashboard/src/components/chat/SessionSidebar.vueclients/web/apps/docs/src/content/docs/guides/architecture/overview.mdclients/web/apps/docs/src/content/docs/es/guides/getting-started.md
**/*.{md,mdx}
⚙️ CodeRabbit configuration file
**/*.{md,mdx}: Verify technical accuracy and that docs stay aligned with code changes.
For user-facing docs, check EN/ES parity or explicitly note pending translation gaps.
Files:
clients/web/apps/docs/src/content/docs/guides/architecture/overview.mdclients/web/apps/docs/src/content/docs/es/guides/getting-started.md
🔇 Additional comments (6)
clients/web/apps/dashboard/src/components/chat/SessionSidebar.vue (1)
254-255: LGTM! Effective active-state visual pattern.The CSS change uses a left accent border combined with an elevated background to improve active item visibility—a solid, accessible pattern. The component retains
aria-current="true"for screen readers, ensuring no accessibility regression.clients/web/apps/docs/src/content/docs/guides/architecture/overview.md (5)
9-10: LGTM: Translation gap properly documented.The frontmatter correctly marks the Spanish translation as pending, which aligns with the guideline to explicitly note EN/ES parity gaps in user-facing docs.
40-42: LGTM: Clear context for unavailable diagrams.The note effectively communicates that the rendering instructions are for future use and directs users to the top-level migration notice for updates.
57-58: LGTM: Generic placeholder addresses past feedback.The generic
<diagram-file>placeholder prevents confusion about specific diagram filenames that don't exist during migration. This directly addresses previous review comments.
66-67: LGTM: Consistent placeholder approach.The generic placeholder matches the Mermaid example approach and addresses previous feedback about avoiding references to specific non-existent diagram files.
72-73: LGTM: Section-specific context helps readers.While these notes repeat the migration theme, they provide valuable inline context for users who may skip to specific sections. The redundancy is appropriate for documentation usability.
Also applies to: 81-82
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Yuniel Acosta Pérez <33158051+yacosta738@users.noreply.github.com>
|
1 participant
Summary
Changes
guides/getting-started.md: Removed trailing slashes from relative linksguides/release.md: Removed trailing slash from gpg-setup linkes/guides/getting-started.md: Replaced broken sub-page links with a notees/guides/release.md: Removed trailing slash from gpg-setup linkguides/architecture/overview.md: Added note about diagramsVerification
pnpm build- passed