Skip to content

refactor(agent-runtime): finalize session command registry routing (#542)#550

Merged
yacosta738 merged 1 commit into
developfrom
feature/dallay-542-finalize-session-command-registry-routing
Apr 17, 2026
Merged

refactor(agent-runtime): finalize session command registry routing (#542)#550
yacosta738 merged 1 commit into
developfrom
feature/dallay-542-finalize-session-command-registry-routing

Conversation

@yacosta738
Copy link
Copy Markdown
Contributor

Related Issues

Fixes #542
Related to #527


Summary

This PR finalizes the session-command registry migration for /resume, /suspend, /tldr, and /compact.

The production migration was already functionally in place, so this change closes the issue by removing leftover registry-routing noise, proving the shared pre_execution::evaluate_ingress(...) seam across CLI/gateway/webhook/channel entrypoints, and syncing the finalized routing guarantees into OpenSpec.


Tested Information

Validated with focused runtime checks and repository hooks:

  • cargo test --manifest-path clients/agent-runtime/Cargo.toml pre_execution::
  • cargo test --manifest-path clients/agent-runtime/Cargo.toml gateway::
  • cargo test --manifest-path clients/agent-runtime/Cargo.toml webhook_dispatch::
  • cargo test --manifest-path clients/agent-runtime/Cargo.toml channels::
  • cargo fmt --manifest-path clients/agent-runtime/Cargo.toml --all -- --check
  • cargo clippy --manifest-path clients/agent-runtime/Cargo.toml --all-targets -- -D warnings
  • pre-push hook: Rust checks + full runtime suite (3562 tests passed)

Reviewers should focus on:

  • removal of the dead SlashCommandRegistry::recognizes(...) helper
  • helper/comment renames that clarify shared handled-ingress routing
  • seam-level regressions proving /resume, /suspend, /tldr, and /compact route through the registry-backed ingress path

Documentation Impact

  • Docs updated in:
    • openspec/specs/slash-command-registry/spec.md
    • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/
  • No docs update required because:
  • I verified the documentation matches the current behavior.

Breaking Changes

None.


Checklist

  • I have checked that there isn’t already a PR solving the same problem.
  • I have read the Contributing Guidelines.
  • I ensured my code follows the project's style guidelines.
  • I have added or updated tests that prove my fix is effective or that my feature works.
  • I have updated the documentation, or I explained above why no documentation update is needed.
  • I verified the documentation matches the current behavior.
  • I have documented any breaking changes in the Breaking Changes section.
  • I have linked the related issue (if any).

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying corvus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 47e585d
Status: ✅  Deploy successful!
Preview URL: https://58db7e83.corvus-42x.pages.dev
Branch Preview URL: https://feature-dallay-542-finalize.corvus-42x.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@yacosta738 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 45 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 98594fb9-a394-49eb-bb08-4aff3bffed12

📥 Commits

Reviewing files that changed from the base of the PR and between a62d026 and 47e585d.

📒 Files selected for processing (14)
  • clients/agent-runtime/src/channels/mod.rs
  • clients/agent-runtime/src/gateway/mod.rs
  • clients/agent-runtime/src/gateway/webhook_dispatch.rs
  • clients/agent-runtime/src/main.rs
  • clients/agent-runtime/src/pre_execution/mod.rs
  • clients/agent-runtime/src/session_commands/registry.rs
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/design.md
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/exploration.md
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/proposal.md
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/specs/slash-command-registry/spec.md
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/state.yaml
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/tasks.md
  • openspec/changes/archive/2026-04-17-finalize-session-command-registry-routing/verify-report.md
  • openspec/specs/slash-command-registry/spec.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/dallay-542-finalize-session-command-registry-routing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Contributor Report

User: @yacosta738
Status: Passed (12/13 metrics passed)

Metric Description Value Threshold Status
PR Merge Rate PRs merged vs closed 89% >= 30%
Repo Quality Repos with ≥100 stars 0 >= 0
Positive Reactions Positive reactions received 11 >= 1
Negative Reactions Negative reactions received 0 <= 5
Account Age GitHub account age 3093 days >= 30 days
Activity Consistency Regular activity over time 108% >= 0%
Issue Engagement Issues with community engagement 0 >= 0
Code Reviews Code reviews given to others 565 >= 0
Merger Diversity Unique maintainers who merged PRs 2 >= 0
Repo History Merge Rate Merge rate in this repo 92% >= 0%
Repo History Min PRs Previous PRs in this repo 248 >= 0
Profile Completeness Profile richness (bio, followers) 90 >= 0
Suspicious Patterns Spam-like activity detection 1 N/A

Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-04-17 to 2026-04-17

@yacosta738 yacosta738 merged commit c7d483f into develop Apr 17, 2026
7 checks passed
@yacosta738 yacosta738 deleted the feature/dallay-542-finalize-session-command-registry-routing branch April 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant