reshape state array for a multiple-state element after solving the roots #11
Open
gdarkwah wants to merge 1 commit intodalmo1991:masterfrom
Open
reshape state array for a multiple-state element after solving the roots #11gdarkwah wants to merge 1 commit intodalmo1991:masterfrom
gdarkwah wants to merge 1 commit intodalmo1991:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am just reopening a previous pull request that I mistakenly closed
For example, an element with 2 states will have two flux functions:
[f1, f2]and two s_zeros:[S0_1, S0_2].Let's say
S0_1=[0, 1, 2, 3, 4]andS0_2=[5, 6, 7, 8, 9], the current implementation of line 170 will return astate_arrayof:instead of:
This means that when you call
get_states()[0]on the element, it will return the first two values inS0_1instead of the firstS0_1andS0_2.The new modification solves the issue. I encountered this while developing a multi-state element for my class project.