Builds show passing but they're actually failing

[ericnewton76]

Your build.ps1 is swallowing up an MSBuild failure and deploying packages...

https://ci.appveyor.com/project/damianh/liblog/builds/21223926#L110

[damianh]

Hmm, build is working locally... 🤔

E:\dev\damianh\LibLog [master ≡]> .\build.ps1
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restoring packages for E:\dev\damianh\LibLog\src\LibLog.Tests\LibLog.Tests.csproj...
  Restoring packages for E:\dev\damianh\LibLog\src\LibLog.Example.Serilog\LibLog.Example.Serilog.csproj...
  Restoring packages for E:\dev\damianh\LibLog\src\LibLog.Example.Log4Net\LibLog.Example.Log4Net.csproj...
  Restoring packages for E:\dev\damianh\LibLog\src\LibLog.Tests.NoLogFwkReferences\LibLog.Tests.NoLogFwkReferences.csproj...
  Restoring packages for E:\dev\damianh\LibLog\src\LibLog.Example.NLog\LibLog.Example.NLog.csproj...
  Restore completed in 60.35 ms for E:\dev\damianh\LibLog\src\LibLog\LibLog.csproj.
  Restore completed in 60.4 ms for E:\dev\damianh\LibLog\src\LibLog.Example.ProvidersOnly\LibLog.Example.ProvidersOnly.csproj.
  Restore completed in 61.1 ms for E:\dev\damianh\LibLog\src\LibLog.Example.ColoredConsoleLogProvider\LibLog.Example.ColoredConsoleLogProvider.csproj.
  Restore completed in 60.4 ms for E:\dev\damianh\LibLog\src\LibLog.Example.Library\LibLog.Example.Library.csproj.
  Generating MSBuild file E:\dev\damianh\LibLog\src\LibLog.Example.NLog\obj\LibLog.Example.NLog.csproj.nuget.g.props.
  Restore completed in 381.73 ms for E:\dev\damianh\LibLog\src\LibLog.Example.NLog\LibLog.Example.NLog.csproj.
  Generating MSBuild file E:\dev\damianh\LibLog\src\LibLog.Example.Serilog\obj\LibLog.Example.Serilog.csproj.nuget.g.props.
  Restore completed in 515.5 ms for E:\dev\damianh\LibLog\src\LibLog.Example.Serilog\LibLog.Example.Serilog.csproj.
  Generating MSBuild file E:\dev\damianh\LibLog\src\LibLog.Tests.NoLogFwkReferences\obj\LibLog.Tests.NoLogFwkReferences.csproj.nuget.g.props.
  Generating MSBuild file E:\dev\damianh\LibLog\src\LibLog.Example.Log4Net\obj\LibLog.Example.Log4Net.csproj.nuget.g.props.
  Restore completed in 553.15 ms for E:\dev\damianh\LibLog\src\LibLog.Tests.NoLogFwkReferences\LibLog.Tests.NoLogFwkReferences.csproj.
  Restore completed in 557.48 ms for E:\dev\damianh\LibLog\src\LibLog.Example.Log4Net\LibLog.Example.Log4Net.csproj.
  Generating MSBuild file E:\dev\damianh\LibLog\src\LibLog.Tests\obj\LibLog.Tests.csproj.nuget.g.props.
  Restore completed in 1.19 sec for E:\dev\damianh\LibLog\src\LibLog.Tests\LibLog.Tests.csproj.
  LibLog -> E:\dev\damianh\LibLog\src\LibLog\bin\Release\net452\LibLog.dll
  LibLog -> E:\dev\damianh\LibLog\src\LibLog\bin\Release\netstandard2.0\LibLog.dll
  LibLog.Example.ProvidersOnly -> E:\dev\damianh\LibLog\src\LibLog.Example.ProvidersOnly\bin\Release\netstandard2.0\LibLog.Example.ProvidersOnly.dll
  LibLog.Example.Library -> E:\dev\damianh\LibLog\src\LibLog.Example.Library\bin\Release\netstandard2.0\LibLog.Example.Library.dll
  LibLog.Example.ColoredConsoleLogProvider -> E:\dev\damianh\LibLog\src\LibLog.Example.ColoredConsoleLogProvider\bin\Release\netcoreapp2.0\LibLog.Example.ColoredConsoleLogProvider.dll
  LibLog.Example.NLog -> E:\dev\damianh\LibLog\src\LibLog.Example.NLog\bin\Release\netcoreapp2.0\LibLog.Example.NLog.dll
  LibLog.Example.Serilog -> E:\dev\damianh\LibLog\src\LibLog.Example.Serilog\bin\Release\netcoreapp2.0\LibLog.Example.Serilog.dll
  LibLog.Example.Log4Net -> E:\dev\damianh\LibLog\src\LibLog.Example.Log4Net\bin\Release\netcoreapp2.0\LibLog.Example.Log4Net.dll
  LibLog.Tests.NoLogFwkReferences -> E:\dev\damianh\LibLog\src\LibLog.Tests.NoLogFwkReferences\bin\Release\netcoreapp2.0\LibLog.Tests.NoLogFwkReferences.dll
  LibLog.Tests.NoLogFwkReferences -> E:\dev\damianh\LibLog\src\LibLog.Tests.NoLogFwkReferences\bin\Release\net452\LibLog.Tests.NoLogFwkReferences.dll
  LibLog.Tests.NoLogFwkReferences -> E:\dev\damianh\LibLog\src\LibLog.Tests.NoLogFwkReferences\bin\Release\net461\LibLog.Tests.NoLogFwkReferences.dll
  LibLog.Tests -> E:\dev\damianh\LibLog\src\LibLog.Tests\bin\Release\net452\LibLog.Tests.dll
  LibLog.Tests -> E:\dev\damianh\LibLog\src\LibLog.Tests\bin\Release\netcoreapp2.0\LibLog.Tests.dll
  LibLog.Tests -> E:\dev\damianh\LibLog\src\LibLog.Tests\bin\Release\net461\LibLog.Tests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:13.19
Test run for E:\dev\damianh\LibLog\src\LibLog.Tests\bin\Release\netcoreapp2.0\LibLog.Tests.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 149. Passed: 149. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 18.6062 Seconds
Test run for E:\dev\damianh\LibLog\src\LibLog.Tests\bin\Release\net461\LibLog.Tests.dll(.NETFramework,Version=v4.6.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 149. Passed: 149. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 22.2014 Seconds
Test run for E:\dev\damianh\LibLog\src\LibLog.Tests\bin\Release\net452\LibLog.Tests.dll(.NETFramework,Version=v4.5.2)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 118. Passed: 118. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 4.0354 Seconds
Attempting to build package from 'LibLog.nuspec'.
Successfully created package 'E:\dev\damianh\LibLog\artifacts\LibLog.5.0.2-build.0.nupkg'.
WARNING: Issue found with package 'LibLog'.

WARNING: Issue: Package version not supported on legacy clients.
WARNING: Description: The package version '5.0.2-build.0' uses SemVer 2.0.0 or components of SemVer 1.0.0 that are not supported on legacy clients. This message can be ignored if the package is not intended for older clients.
WARNING: Solution: Change the package version to a SemVer 1.0.0 string. If the version contains a release label it must start with a letter.

[damianh]

Fixed in 61dd804 and bc09b13

Thanks for reporting :)